From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 5D7B47D90D for ; Mon, 8 Jul 2019 19:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731473AbfGHTyG (ORCPT ); Mon, 8 Jul 2019 15:54:06 -0400 Received: from ms.lwn.net ([45.79.88.28]:53198 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727163AbfGHTyG (ORCPT ); Mon, 8 Jul 2019 15:54:06 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id EDECC2B8; Mon, 8 Jul 2019 19:54:05 +0000 (UTC) Date: Mon, 8 Jul 2019 13:54:04 -0600 From: Jonathan Corbet To: Luke Nowakowski-Krijger Cc: linux-kernel-mentees@lists.linuxfoundation.org, pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Documentation: virtual: Add toctree hooks Message-ID: <20190708135404.3eeed68f@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sat, 6 Jul 2019 14:38:13 -0700 Luke Nowakowski-Krijger wrote: > From: Luke Nowakowski-Krijger > > Added toctree hooks for indexing. Hooks added only for newly added files > or already existing files. > > The hook for the top of the tree will be added in a later patch series > when a few more substantial changes have been added. > > Signed-off-by: Luke Nowakowski-Krijger > --- > Documentation/virtual/index.rst | 18 ++++++++++++++++++ > Documentation/virtual/kvm/index.rst | 12 ++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 Documentation/virtual/index.rst > create mode 100644 Documentation/virtual/kvm/index.rst > > diff --git a/Documentation/virtual/index.rst b/Documentation/virtual/index.rst > new file mode 100644 > index 000000000000..19c9fa2266f4 > --- /dev/null > +++ b/Documentation/virtual/index.rst > @@ -0,0 +1,18 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +=========================== > +Linux Virtual Documentation > +=========================== > + > +.. toctree:: > + :maxdepth: 2 > + > + kvm/index > + paravirt_ops > + > +.. only:: html and subproject > + > + Indices > + ======= > + > + * :ref:`genindex` > diff --git a/Documentation/virtual/kvm/index.rst b/Documentation/virtual/kvm/index.rst > new file mode 100644 > index 000000000000..ada224a511fe > --- /dev/null > +++ b/Documentation/virtual/kvm/index.rst > @@ -0,0 +1,12 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +=== > +KVM > +=== > + > +.. toctree:: > + :maxdepth: 2 > + > + amd-memory-encryption > + cpuid > + vcpu-requests At this point in the patch series, the above-mentioned RST files don't exist. So if somebody tries to build the docs here, the build will fail. I suspect that it's pretty rare for people to use bisection with docs builds, but it's still proper practice to ensure that things work at every step in your series. So the above entries should be added in the patches that convert the files. Also, vcpu-requests.txt is never touched in this patch series, which suggests that you didn't build the docs even at the end of it. Thanks, jon