From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id CC80A7D90D for ; Mon, 8 Jul 2019 20:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732047AbfGHU2N (ORCPT ); Mon, 8 Jul 2019 16:28:13 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38984 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfGHU2N (ORCPT ); Mon, 8 Jul 2019 16:28:13 -0400 Received: by mail-lj1-f195.google.com with SMTP id v18so17260167ljh.6 for ; Mon, 08 Jul 2019 13:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eng.ucsd.edu; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aP50fU9jWh1SVwYTLC+Bnr2NJDpeCgQBUG33TJZRv3c=; b=O9TVM7vPx877J6GvjeRwcyAevrgRrCuSS8pcoeJlEHDIViI420nOnFbTzd2KdqHImt LUIC0flvjlPO8E3m0D1RH+5iydfGexIVXmCQSpk1/gC9ovhgdt1bBeeCH4oKESBwzqeV 2XeX4oxEZjXCAld8+vGogj5AhlRTWc2sU2VMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aP50fU9jWh1SVwYTLC+Bnr2NJDpeCgQBUG33TJZRv3c=; b=peNZ99sibX8kT/h3Mxvs7LoE21es/nG496ULdjIQTUv8QcFSZYa2Jg72yEiFQjfcuI hXHqwv1FqGWGR8Eeb1bgeGYw9KcCNpsHGmQmazL8c/HSw0KTZzcCVM4IY03lZFXiSOtz KQltQjfDUTITkDhAHSCFrrNlBeWGVu4Omq0gwpCVmSwcBFkGeJlVwNFhy5hPy2uuN+27 4VESH/dL0OIrJhjMLhyaBPu4oS3RCSaGHRD8nZyO7BKcxgjfmAHJeawF4gCixlmAIPHy vMaaxMdXds3JeEgbA+x0YboIerApXEAQKKpn+1UvxCoewyWaGytVw0rJa5i3c0KLOewI NjfQ== X-Gm-Message-State: APjAAAX6uLCBO0/h1HKwcy2W2tid7+qi3nE2wbuHe5EYMTODPncA15Fy PG3zGY7e5bllcjlPNLggaEQa1Q== X-Google-Smtp-Source: APXvYqyqusmub7bifQwEMHiihwOyK5Pb+umaZm2KbS0Q9R3gTIIIHnNVYU0MymObvFosL9+y+wrpiA== X-Received: by 2002:a2e:b60f:: with SMTP id r15mr9591215ljn.172.1562617691526; Mon, 08 Jul 2019 13:28:11 -0700 (PDT) Received: from luke-XPS-13 (77-255-206-190.adsl.inetia.pl. [77.255.206.190]) by smtp.gmail.com with ESMTPSA id l11sm2934729lfk.1.2019.07.08.13.28.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 13:28:10 -0700 (PDT) Date: Mon, 8 Jul 2019 13:28:08 -0700 From: Luke Nowakowski-Krijger To: Jonathan Corbet Cc: linux-kernel-mentees@lists.linuxfoundation.org, pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Documentation: virtual: Add toctree hooks Message-ID: <20190708202808.GA8859@luke-XPS-13> References: <20190708135404.3eeed68f@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708135404.3eeed68f@lwn.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Jul 08, 2019 at 01:54:04PM -0600, Jonathan Corbet wrote: > On Sat, 6 Jul 2019 14:38:13 -0700 > Luke Nowakowski-Krijger wrote: > > At this point in the patch series, the above-mentioned RST files don't > exist. So if somebody tries to build the docs here, the build will fail. > I suspect that it's pretty rare for people to use bisection with docs > builds, but it's still proper practice to ensure that things work at every > step in your series. So the above entries should be added in the patches > that convert the files. > Yes, agreed. It should be at the end of the series. > Also, vcpu-requests.txt is never touched in this patch series, which > suggests that you didn't build the docs even at the end of it. > In the staging tree I was doing work out of I saw a vcpu-requests.rst file so thought I could add it "while I'm here". You're right. I should only add the files I am converting. > Thanks, > > jon Thanks again, - Luke