From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: gregkh@linuxfoundation.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 06/20] docs: kernel_abi.py: fix UTF-8 support
Date: Wed, 17 Jul 2019 09:30:25 -0300 [thread overview]
Message-ID: <20190717093025.443ecbf7@coco.lan> (raw)
In-Reply-To: <fd4ae75a-3cb3-3f26-8891-e503451355b9@darmarit.de>
Em Wed, 17 Jul 2019 13:44:40 +0200
Markus Heiser <markus.heiser@darmarit.de> escreveu:
> Hi Mauro,
>
> just nitpicking ..
>
> Am 17.07.19 um 13:05 schrieb Mauro Carvalho Chehab:
> > The parser breaks with UTF-8 characters with Sphinx 1.4.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> > Documentation/sphinx/kernel_abi.py | 20 +++++++-------------
> > 1 file changed, 7 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/sphinx/kernel_abi.py b/Documentation/sphinx/kernel_abi.py
> > index 32ce90775d96..0f3e51e67e8d 100644
> > --- a/Documentation/sphinx/kernel_abi.py
> > +++ b/Documentation/sphinx/kernel_abi.py
> > @@ -1,4 +1,5 @@
> > -# -*- coding: utf-8; mode: python -*-
> > +# coding=utf-8
>
> Can we use the more common::
>
> # -*- coding: utf-8 -*-
>
> notation? See [1] """using formats recognized by popular editors"""
>
> If I'am not wrong, I remember we had this 'magic comment' discussion in the past.
Changed. I ended by merging this change, together with the SPDX one at
the initial patch and did some other patch merges, in order to provide
a cleaner history.
Thanks,
Mauro
next prev parent reply other threads:[~2019-07-17 12:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1563360659.git.mchehab+samsung@kernel.org>
2019-07-17 11:05 ` [PATCH v3 04/20] docs: kernellog.py: add support for info() Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 05/20] docs: kernel_abi.py: add a script to parse ABI documentation Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 06/20] docs: kernel_abi.py: fix UTF-8 support Mauro Carvalho Chehab
2019-07-17 11:44 ` Markus Heiser
2019-07-17 12:30 ` Mauro Carvalho Chehab [this message]
2019-07-17 11:05 ` [PATCH v3 07/20] docs: kernel_abi.py: make it compatible with Sphinx 1.7+ Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 08/20] docs: kernel_abi.py: Update copyrights Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 09/20] docs: kernel_abi.py: add a SPDX header file Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 10/20] docs: kernel_abi.py: use --enable-lineno for get_abi.pl Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 11/20] docs: kernel_abi.py: Handle with a lazy Sphinx parser Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 12/20] docs: add ABI documentation to the admin-guide book Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 16/20] docs: ABI: make it parse ABI/stable as ReST-compatible files Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 17/20] docs: ABI: create a 2-depth index for ABI Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 18/20] docs: ABI: don't escape ReST-incompatible chars from obsolete and removed Mauro Carvalho Chehab
2019-07-28 22:02 ` Linus Walleij
2019-07-17 11:05 ` [PATCH v3 19/20] docs: abi-testing.rst: enable --rst-sources when building docs Mauro Carvalho Chehab
2019-07-17 11:05 ` [PATCH v3 20/20] docs: Kconfig/Makefile: add a check for broken ABI files Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717093025.443ecbf7@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).