From: Matthew Wilcox <willy@infradead.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>, Tri Vo <trong@android.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] idr: Document calling context for IDA APIs mustn't use locks
Date: Tue, 30 Jul 2019 14:12:50 -0700 [thread overview]
Message-ID: <20190730211250.GD4700@bombadil.infradead.org> (raw)
In-Reply-To: <20190730210752.157700-1-swboyd@chromium.org>
On Tue, Jul 30, 2019 at 02:07:52PM -0700, Stephen Boyd wrote:
> The documentation for these functions indicates that callers don't need
> to hold a lock while calling them, but that documentation is only in one
> place under "IDA Usage". Let's state the same information on each IDA
> function so that it's clear what the calling context requires.
> Furthermore, let's document ida_simple_get() with the same information
> so that callers know how this API works.
I don't want people to use ida_simple_get() any more. Use ida_alloc()
instead.
> - * Context: Any context.
> + * Context: Any context. It is safe to call this function without
> + * synchronisation in your code.
I prefer "without locking" to "without synchronisation" ...
next prev parent reply other threads:[~2019-07-30 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 21:07 [PATCH] idr: Document calling context for IDA APIs mustn't use locks Stephen Boyd
2019-07-30 21:12 ` Matthew Wilcox [this message]
2019-07-30 21:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730211250.GD4700@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=trong@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox