From: Nathan Chancellor <natechancellor@gmail.com>
To: saravanak@google.com
Cc: collinsd@codeaurora.org, corbet@lwn.net,
devicetree@vger.kernel.org, frowand.list@gmail.com,
gregkh@linuxfoundation.org, kernel-team@android.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, rafael@kernel.org, robh+dt@kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
kbuild test robot <lkp@intel.com>
Subject: [PATCH] of/platform: Add missing const qualifier in of_link_property
Date: Wed, 31 Jul 2019 11:17:34 -0700 [thread overview]
Message-ID: <20190731181733.60422-1-natechancellor@gmail.com> (raw)
In-Reply-To: <20190729221101.228240-4-saravanak@google.com>
Clang errors:
drivers/of/platform.c:632:28: error: initializing 'struct
supplier_bindings *' with an expression of type 'const struct
supplier_bindings [4]' discards qualifiers
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]
struct supplier_bindings *s = bindings;
^ ~~~~~~~~
1 error generated.
Fixes: 05f812549f53 ("of/platform: Add functional dependency link from DT bindings")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
Given this is still in the driver-core-testing branch, I am fine with
this being squashed in if desired.
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index e2da90e53edb..21838226d68a 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -629,7 +629,7 @@ static bool of_link_property(struct device *dev, struct device_node *con_np,
const char *prop)
{
struct device_node *phandle;
- struct supplier_bindings *s = bindings;
+ const struct supplier_bindings *s = bindings;
unsigned int i = 0;
bool done = true, matched = false;
--
2.22.0
next prev parent reply other threads:[~2019-07-31 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190729221101.228240-1-saravanak@google.com>
2019-07-29 22:10 ` [PATCH v8 3/7] of/platform: Add functional dependency link from DT bindings Saravana Kannan
2019-07-31 18:17 ` Nathan Chancellor [this message]
2019-07-31 20:33 ` [PATCH] of/platform: Add missing const qualifier in of_link_property Saravana Kannan
2019-07-31 20:37 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731181733.60422-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=collinsd@codeaurora.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).