From: Greg KH <gregkh@linuxfoundation.org>
To: Wu Hao <hao.wu@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-doc@vger.kernel.org, atull@kernel.org,
Luwei Kang <luwei.kang@intel.com>,
Ananda Ravuri <ananda.ravuri@intel.com>,
Xu Yilun <yilun.xu@intel.com>
Subject: Re: [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support
Date: Wed, 7 Aug 2019 11:30:58 +0200 [thread overview]
Message-ID: <20190807093058.GA8326@kroah.com> (raw)
In-Reply-To: <20190807080825.GA10344@hao-dev>
On Wed, Aug 07, 2019 at 04:08:25PM +0800, Wu Hao wrote:
> On Wed, Aug 07, 2019 at 10:45:22AM +0800, Wu Hao wrote:
> > On Mon, Aug 05, 2019 at 05:56:26PM +0200, Greg KH wrote:
> > > On Sun, Aug 04, 2019 at 06:20:21PM +0800, Wu Hao wrote:
> > > > +static int fme_global_err_init(struct platform_device *pdev,
> > > > + struct dfl_feature *feature)
> > > > +{
> > > > + struct device *dev;
> > > > + int ret = 0;
> > > > +
> > > > + dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> > > > + if (!dev)
> > > > + return -ENOMEM;
> > > > +
> > > > + dev->parent = &pdev->dev;
> > > > + dev->release = err_dev_release;
> > > > + dev_set_name(dev, "errors");
> > > > +
> > > > + fme_error_enable(feature);
> > > > +
> > > > + ret = device_register(dev);
> > > > + if (ret) {
> > > > + put_device(dev);
> > > > + return ret;
> > > > + }
> > > > +
> > > > + ret = device_add_groups(dev, error_groups);
> > >
> > > cute, but no, you do not create a whole struct device for a subdir. Use
> > > the attribute group name like you did on earlier patches.
> >
> > Sure, let me fix it in the next version.
> >
> > >
> > > And again, you raced userspace and lost :(
> >
> > Same here, could you please give some more hints here?
>
> Oh.. I see..
>
> I should follow [1] as this is a platform driver. I will fix it. Thanks!
>
> [PATCH 00/11] Platform drivers, provide a way to add sysfs groups easily
>
> [1]https://lkml.org/lkml/2019/7/4/181
Yes, that is the correct thing to do.
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-07 9:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 10:20 [PATCH v4 00/12] FPGA DFL updates Wu Hao
2019-08-04 10:20 ` [PATCH v4 01/12] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support Wu Hao
2019-08-04 10:20 ` [PATCH v4 02/12] fpga: dfl: pci: enable SRIOV support Wu Hao
2019-08-04 10:20 ` [PATCH v4 03/12] fpga: dfl: afu: add AFU state related sysfs interfaces Wu Hao
2019-08-04 10:20 ` [PATCH v4 04/12] fpga: dfl: afu: add userclock " Wu Hao
2019-08-05 15:51 ` Greg KH
2019-08-07 2:18 ` Wu Hao
2019-08-04 10:20 ` [PATCH v4 05/12] fpga: dfl: add id_table for dfl private feature driver Wu Hao
2019-08-04 10:20 ` [PATCH v4 06/12] fpga: dfl: afu: export __port_enable/disable function Wu Hao
2019-08-05 15:52 ` Greg KH
2019-08-07 2:21 ` Wu Hao
2019-08-04 10:20 ` [PATCH v4 07/12] fpga: dfl: afu: add error reporting support Wu Hao
2019-08-05 15:54 ` Greg KH
2019-08-07 2:35 ` Wu Hao
2019-08-04 10:20 ` [PATCH v4 08/12] fpga: dfl: make uinit callback optional Wu Hao
2019-08-09 19:51 ` Moritz Fischer
2019-08-04 10:20 ` [PATCH v4 09/12] fpga: dfl: afu: add STP (SignalTap) support Wu Hao
2019-08-04 10:20 ` [PATCH v4 10/12] fpga: dfl: fme: add capability sysfs interfaces Wu Hao
2019-08-04 10:20 ` [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support Wu Hao
2019-08-05 15:56 ` Greg KH
2019-08-07 2:45 ` Wu Hao
2019-08-07 8:08 ` Wu Hao
2019-08-07 9:30 ` Greg KH [this message]
2019-08-04 10:20 ` [PATCH v4 12/12] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces Wu Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807093058.GA8326@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ananda.ravuri@intel.com \
--cc=atull@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mdf@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).