From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 9CD257D2F0 for ; Mon, 12 Aug 2019 05:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725854AbfHLFDA (ORCPT ); Mon, 12 Aug 2019 01:03:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:42274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfHLFDA (ORCPT ); Mon, 12 Aug 2019 01:03:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A7320842; Mon, 12 Aug 2019 05:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565586178; bh=dkXz6e/E5uuKCjklSsio9Wi/z0A/ofiJ0WK3lYOv9I0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fT8rKH3ZfEKa3aaCJ3w/qjJiTZogdSB366BUTlCy64cqkbHQjl/vPdnjNhGwe2rwq Of+b8YNEsxtk4PrxSPLAjYq78YQY/NCTMajihlv/b0Es50X/F+xy/V951fFSFDauQy jrIxTuXD6NzDJOHkwIOpOBm/SB28M2sirMimZZ+Y= Date: Mon, 12 Aug 2019 07:02:56 +0200 From: Greg Kroah-Hartman To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, kbuild test robot , Jonathan Corbet , Josh Triplett , Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , "Paul E. McKenney" , "Rafael J. Wysocki" , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo Subject: Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled Message-ID: <20190812050256.GC5834@kroah.com> References: <20190811221111.99401-1-joel@joelfernandes.org> <20190811221111.99401-3-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811221111.99401-3-joel@joelfernandes.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sun, Aug 11, 2019 at 06:11:11PM -0400, Joel Fernandes (Google) wrote: > Properly check if lockdep lock checking is disabled at config time. If > so, then lock_is_held() is undefined so don't do any checking. > > This fix is similar to the pattern used in srcu_read_lock_held(). > > Link: https://lore.kernel.org/lkml/201908080026.WSAFx14k%25lkp@intel.com/ > Fixes: c9e4d3a2fee8 ("acpi: Use built-in RCU list checking for acpi_ioremaps list") What tree is this commit in? > Reported-by: kbuild test robot > Signed-off-by: Joel Fernandes (Google) > --- > This patch is based on the -rcu dev branch. Ah... > drivers/base/core.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 32cf83d1c744..fe25cf690562 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -99,7 +99,11 @@ void device_links_read_unlock(int not_used) > > int device_links_read_lock_held(void) > { > - return lock_is_held(&device_links_lock); > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > + return lock_is_held(&(device_links_lock.dep_map)); > +#else > + return 1; > +#endif return 1? So the lock is always held? confused, greg k-h