From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 59BFF7D90D for ; Sat, 24 Aug 2019 21:24:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727708AbfHXVYz (ORCPT ); Sat, 24 Aug 2019 17:24:55 -0400 Received: from ms.lwn.net ([45.79.88.28]:50340 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727690AbfHXVYy (ORCPT ); Sat, 24 Aug 2019 17:24:54 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 1BB5B300; Sat, 24 Aug 2019 21:24:54 +0000 (UTC) Date: Sat, 24 Aug 2019 15:24:53 -0600 From: Jonathan Corbet To: Andreas Dilger Cc: Ayush Ranjan , Theodore Ts'o , Andreas Dilger , Ext4 Developers List , linux-doc@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v2] Ext4 documentation fixes. Message-ID: <20190824152453.03737143@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 15 Aug 2019 09:16:23 -0700 Andreas Dilger wrote: > On Aug 15, 2019, at 09:11, Ayush Ranjan wrote: > > > > This commit aims to fix the following issues in ext4 documentation: > > - Flexible block group docs said that the aim was to group block > > metadata together instead of block group metadata. > > - The documentation consistly uses "location" instead of "block number". > > It is easy to confuse location to be an absolute offset on disk. Added > > a line to clarify all location values are in terms of block numbers. > > - Dirent2 docs said that the rec_len field is shortened instead of the > > name_len field. > > - Typo in bg_checksum description. > > - Inode size is 160 bytes now, and hence i_extra_isize is now 32. > > - Cluster size formula was incorrect, it did not include the +10 to > > s_log_cluster_size value. > > - Typo: there were two s_wtime_hi in the superblock struct. > > - Superblock struct was outdated, added the new fields which were part > > of s_reserved earlier. > > - Multiple mount protection seems to be implemented in fs/ext4/mmp.c. > > > > Signed-off-by: Ayush Ranjan > > Reviewed-by: Andreas Dilger I've applied this to the docs tree. However, Ayush: the patch was rather badly corrupted by your mail client. I managed to fix it up, but please in the future verify that you can email a patch to yourself and apply it before submitting it. There may be some useful hints in Documentation/process/email-clients.rst . Thanks, jon