From: Matthew Wilcox <willy@infradead.org>
To: Peter Rosin <peda@axentia.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jonathan Corbet <corbet@lwn.net>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos
Date: Sat, 24 Aug 2019 08:34:46 -0700 [thread overview]
Message-ID: <20190824153446.GB28002@bombadil.infradead.org> (raw)
In-Reply-To: <20190823084725.4271-3-peda@axentia.se>
On Fri, Aug 23, 2019 at 08:47:47AM +0000, Peter Rosin wrote:
> +++ b/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -56,6 +56,9 @@ EXPORT_SYMBOL(num_registered_fb);
> bool fb_center_logo __read_mostly;
> EXPORT_SYMBOL(fb_center_logo);
>
> +unsigned int fb_logo_count __read_mostly;
> +EXPORT_SYMBOL(fb_logo_count);
Why does this symbol need to be exported? As I read the Makefile, fbcon
and fbmem are combined into the same module, so while the symbol needs
to be non-static, it doesn't need to be exported to other modules.
next prev parent reply other threads:[~2019-08-24 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 8:47 [PATCH 0/2] Add possibility to specify the number of displayed logos Peter Rosin
2019-08-23 8:47 ` [PATCH 1/2] fbdev: fix numbering of fbcon options Peter Rosin
2019-08-23 8:47 ` [PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos Peter Rosin
2019-08-24 15:34 ` Matthew Wilcox [this message]
2019-08-25 9:35 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824153446.GB28002@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox