From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 8E8D17D2F0 for ; Wed, 28 Aug 2019 20:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbfH1UfB (ORCPT ); Wed, 28 Aug 2019 16:35:01 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44349 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbfH1UfA (ORCPT ); Wed, 28 Aug 2019 16:35:00 -0400 Received: by mail-pl1-f194.google.com with SMTP id t14so479641plr.11 for ; Wed, 28 Aug 2019 13:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=upwaiJ61BH1IpIswTLq+2j1brd6YlJwq3xhLh2FJl/Q=; b=j0BmqqfF2dUwzXmcTIDGocquJMKbOF2wEU+8SAdj+xEVuSMZZt2jvoMBCH9qUDV+W4 uhp73qjEXaaGHfOJZyoJqtVlxC+xLcYkpu4P4xSXiVYog59x/FImui1wixg9OrquFFcn gpjMbjgO+WQ7poBwG4DFhCjIajmLZEDP1B0ec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=upwaiJ61BH1IpIswTLq+2j1brd6YlJwq3xhLh2FJl/Q=; b=bGoD5fhF++w6+w/ykpbWbVyANR9TL5Gu3TTt8tDyF9gnrdCpFkgA5h/PYk3ak60A0G wOp2W/iHibiDMyQdmKPRIYPdS/jBqkbmFfY4Y7/YDeAuJu9Xu+I60LzyM4Z7TcyoWQFn ROVSAYdSmKk1X7oGTm7cBn/20Ih0YN6RHw4ZtDVPhWRv2BroDnGj9Bm8gPg1MWU4ADKF 7zrA1RKrQuKpQDUNHFME7S/nfIUH2P72/WaKVLgwLDNRlMFXemfsUuu5T2RkUnV9AdUY sdkHgRz5Bv7aihYrVZhB5M1ORgsfPRso53N8YddaVzPYIDxA1iHy2pRJS68+4yKe1sZV oeWQ== X-Gm-Message-State: APjAAAXB3hOwNpmUooNTYkMhbdfk75aFb+48h9Hgt/JazwikcnWsbZn3 +rNdFlzX4mh5m2NAfHfp/kn8hw== X-Google-Smtp-Source: APXvYqwnZzm4cK0z1wLUekxhHBcwsIiezmmxCb7nn4XUc+uSnyrmAgKCD6uVOWydivR5Imi9QmdyUw== X-Received: by 2002:a17:902:a410:: with SMTP id p16mr6220611plq.150.1567024500119; Wed, 28 Aug 2019 13:35:00 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id y14sm62881pge.7.2019.08.28.13.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 13:34:59 -0700 (PDT) Date: Wed, 28 Aug 2019 16:34:58 -0400 From: Joel Fernandes To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, byungchul.park@lge.com, Josh Triplett , Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , rcu@vger.kernel.org, Steven Rostedt , kernel-team@android.com Subject: Re: [PATCH 0/5] kfree_rcu() additions for -rcu Message-ID: <20190828203458.GA75931@google.com> References: <5d657e30.1c69fb81.54250.01dc@mx.google.com> <20190828202808.GT26530@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828202808.GT26530@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Aug 28, 2019 at 01:28:08PM -0700, Paul E. McKenney wrote: > On Tue, Aug 27, 2019 at 03:01:54PM -0400, Joel Fernandes (Google) wrote: > > Hi, > > > > This is a series on top of the patch "rcu/tree: Add basic support for kfree_rcu() batching". > > > > Link: http://lore.kernel.org/r/20190814160411.58591-1-joel@joelfernandes.org > > > > It adds performance tests, some clean ups and removal of "lazy" RCU callbacks. > > > > Now that kfree_rcu() is handled separately from call_rcu(), we also get rid of > > kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. > > This also results in a nice negative delta as well. > > > > Joel Fernandes (Google) (5): > > rcu/rcuperf: Add kfree_rcu() performance Tests > > rcu/tree: Add multiple in-flight batches of kfree_rcu work > > rcu/tree: Add support for debug_objects debugging for kfree_rcu() > > rcu: Remove kfree_rcu() special casing and lazy handling > > rcu: Remove kfree_call_rcu_nobatch() > > > > Documentation/RCU/stallwarn.txt | 13 +- > > .../admin-guide/kernel-parameters.txt | 13 ++ > > include/linux/rcu_segcblist.h | 2 - > > include/linux/rcutiny.h | 5 - > > include/linux/rcutree.h | 1 - > > include/trace/events/rcu.h | 32 ++-- > > kernel/rcu/rcu.h | 27 --- > > kernel/rcu/rcu_segcblist.c | 25 +-- > > kernel/rcu/rcu_segcblist.h | 25 +-- > > kernel/rcu/rcuperf.c | 173 +++++++++++++++++- > > kernel/rcu/srcutree.c | 4 +- > > kernel/rcu/tiny.c | 29 ++- > > kernel/rcu/tree.c | 145 ++++++++++----- > > kernel/rcu/tree.h | 1 - > > kernel/rcu/tree_plugin.h | 42 +---- > > kernel/rcu/tree_stall.h | 6 +- > > 16 files changed, 337 insertions(+), 206 deletions(-) > > Looks like a 131-line positive delta to me. ;-) Not if you overlook the rcuperf changes which is just test code. :-D ;-) thanks, - Joel