From: Pavel Machek <pavel@denx.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pavel Machek <pavel@denx.de>, Borislav Petkov <bp@alien8.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chen Yu <yu.c.chen@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Juergen Gross <jgross@suse.com>,
Kees Cook <keescook@chromium.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 4.19 72/98] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h
Date: Thu, 29 Aug 2019 00:05:33 +0200 [thread overview]
Message-ID: <20190828220533.GA24056@amd> (raw)
In-Reply-To: <alpine.DEB.2.21.1908281610310.23149@nanos.tec.linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]
On Wed 2019-08-28 16:15:06, Thomas Gleixner wrote:
> On Wed, 28 Aug 2019, Pavel Machek wrote:
> > On Wed 2019-08-28 14:46:21, Borislav Petkov wrote:
> > > On Wed, Aug 28, 2019 at 02:29:13PM +0200, Pavel Machek wrote:
> > > > This is not a way to have an inteligent conversation.
> > >
> > > No, this *is* the way to keep the conversation sane, without veering
> > > off into some absurd claims.
> > >
> > > So, to cut to the chase: you can simply add "rdrand=force" to your
> > > cmdline parameters and get back to using RDRAND.
> > >
> > > And yet if you still feel this fix does not meet your expectations,
> > > you were told already to either produce patches or who to contact. I'm
> > > afraid complaining on this thread won't get you anywhere but that's your
> > > call.
> >
> > No, this does not meet my expectations, it violates stable kernel
> > rules, and will cause regression to some users, while better solution
> > is known to be available.
>
> Your unqualified ranting does not meet my expectation either and it
> violates any rule of common sense.
>
> For the record:
>
> Neither AMD nor we have any idea which particular machines have a fixed
> BIOS and which have not. There is no technical indicator either at boot
> time as the wreckage manifests itself only after resume.
>
> So in the interest of users the only sensible decision is to disable
> RDRAND for this class of CPUs.
No.
Obviously best solution would be microcode update to fix the problem,
or to enable kernel to fix the problem.
> If you have a list of machines which have a fixed BIOS, then provide it
> in form of patches. If not then stop claiming that there is a better
> solution available.
And yes, whitelist would be already better than present solution. It is
not my duty to submit fixes to your proposed patch.
> Anyway, I'm done with that and further rants of yours go directly to
> /dev/null.
>
> Thanks for wasting everyones time
Thanks for your profesional attitude.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2019-08-28 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190827072718.142728620@linuxfoundation.org>
2019-08-27 7:50 ` [PATCH 4.19 72/98] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h Greg Kroah-Hartman
2019-08-27 11:36 ` Pavel Machek
2019-08-27 13:30 ` Thomas Gleixner
2019-08-28 10:31 ` Pavel Machek
2019-08-28 10:47 ` Thomas Gleixner
2019-08-28 11:49 ` Pavel Machek
2019-08-28 12:00 ` Borislav Petkov
2019-08-28 12:09 ` Pavel Machek
2019-08-28 12:16 ` Borislav Petkov
2019-08-28 12:29 ` Pavel Machek
2019-08-28 12:46 ` Borislav Petkov
2019-08-28 13:37 ` Pavel Machek
2019-08-28 14:15 ` Thomas Gleixner
2019-08-28 22:05 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828220533.GA24056@amd \
--to=pavel@denx.de \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=pbonzini@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).