From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id EA7417D910 for ; Thu, 19 Sep 2019 21:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389696AbfISVTJ (ORCPT ); Thu, 19 Sep 2019 17:19:09 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36446 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389222AbfISVTJ (ORCPT ); Thu, 19 Sep 2019 17:19:09 -0400 Received: by mail-pf1-f196.google.com with SMTP id y22so3117986pfr.3 for ; Thu, 19 Sep 2019 14:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UC6QOlPtFT4L7gAheGuvmlsU7X18QM5xfLgyP/nfovU=; b=TenY/nIF7r7AdT+DbY/MGs07XLbBYbYB48QaTr8BR5xkPDPdFERhf51rjGe3hCmhsS b8Lj5e/Uq+1231XB+btSn0lJ8ydUKyHp5gXzFJ167/FMVN2NcDdzlvLpekeY1+73P9R+ ZdwDUdLaVeSZ+JxQTu1Ano0gST3u/0h/mEasM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UC6QOlPtFT4L7gAheGuvmlsU7X18QM5xfLgyP/nfovU=; b=NoAKOGF4L/mRDZLyz9wo7mNpl7+Mn4YWe6sw4KTXPb90eXj1jS2JaIt4w7yXyO0dpr bAo/fM9vZtBRjhV6yZzXhFs3f8M0D7RNYcKKg5qnUymGZMls7QcACB5Sv3qhwoKx8XBK 0TEj28SfcIdoRCkpKfVdbMCY3ly3leiyoEzuTguFgV+p+ch/Q0DrRSGsO26z8YUkJkJU BknVDivV9TR3lJlDMJyBBnJGmHHPpf7eD5Qr+FtxhqayevMznMFxGeWQQzfXc3htjOq7 GlCGzSgSCeLGCGhJmteIH/MbjVTDl2WImRLfW3/XA+CTnVHVDNpdpvJl2kA3D/cypAvA f/5g== X-Gm-Message-State: APjAAAWn195oVKvhgB2NWbM+yHHijpXdPxlb+O2oADifuoRAzkamq4vA pzaC9TaIi1mJPwUq8/SB9bwZ/lfdAgs= X-Google-Smtp-Source: APXvYqyivzuDow60MKYUgF2hsOkA5SUuSL3Vyv4HlcnvRX2I63cnPL2BPFkFJNZYyVKJygjTqr2CCQ== X-Received: by 2002:a17:90a:310:: with SMTP id 16mr125647pje.100.1568927946393; Thu, 19 Sep 2019 14:19:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y4sm5933542pjn.19.2019.09.19.14.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 14:19:05 -0700 (PDT) Date: Thu, 19 Sep 2019 14:19:04 -0700 From: Kees Cook To: Mauro Carvalho Chehab Cc: Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs: Use make invocation's -j argument for parallelism Message-ID: <201909191417.6E59C942@keescook> References: <201909191116.192A096C68@keescook> <20190919162549.5ccdab62@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190919162549.5ccdab62@coco.lan> Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Sep 19, 2019 at 04:25:49PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 19 Sep 2019 11:18:52 -0700 > Kees Cook escreveu: > > [...] > > +# Fetch the make environment options. > > +flags = os.environ.get('MAKEFLAGS', None) > > +if flags == None: > > + print("1") > > + sys.exit(0) > > + > > +# Look for "--jobserver=R,W" > > +opts = [x for x in flags.split(" ") if x.startswith("--jobserver")] > > +if len(opts) != 1: > > + print("1") > > + sys.exit(0) > > Using "1" as default if -j is not specified doesn't sound a good idea. I > mean, Sphinx is very slow without any parallelism. I would keep "auto" as > default here, if version >= 1.7 (and if there's no explicit SPHINXOPTS). Okay, that's fair. This does introduce a behavioral regression from that perspective. Let me spin a v2 that'll DTRT. -- Kees Cook