From: Jonathan Corbet <corbet@lwn.net>
To: Kees Cook <keescook@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] docs: Programmatically render MAINTAINERS into ReST
Date: Tue, 1 Oct 2019 11:36:29 -0600 [thread overview]
Message-ID: <20191001113629.6cdb1abb@lwn.net> (raw)
In-Reply-To: <201910010916.8B8248222@keescook>
On Tue, 1 Oct 2019 09:27:29 -0700
Kees Cook <keescook@chromium.org> wrote:
> On Tue, Oct 01, 2019 at 08:31:47AM -0600, Jonathan Corbet wrote:
> > On a separate note...it occurred to me, rather belatedly as usual, that
> > last time we discussed doing this that there was some opposition to adding
> > a second MAINTAINERS parser to the kernel; future changes to the format of
> > that file may force both to be adjusted, and somebody will invariably
> > forget one. Addressing that, if we feel a need to do so, probably requires
> > tweaking get_maintainer.pl to output the information in a useful format.
>
> That's a reasonable point, but I would make two observations:
>
> - get_maintainers.pl is written in Perl and I really don't want to write
> more Perl. ;)
Trust me, I get it!
> - the parsing methods in get_maintainers is much more focused on the
> file/pattern matching and is blind to the structure of the rest
> of the document (it only examines '^[A-Z]:' and blank lines), and
> does so "on demand", in that it hunts through the entire MAINTAINERS
> file contents for each path match.
>
> So I don't think it's suitable to merge functionality here...
Makes sense to me. If anybody out there objects, speak now ...
jon
prev parent reply other threads:[~2019-10-01 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 23:02 [PATCH 0/2] docs: Programmatically render MAINTAINERS into ReST Kees Cook
2019-09-24 23:02 ` [PATCH 1/2] doc-rst: Reduce CSS padding around Field Kees Cook
2019-09-24 23:02 ` [PATCH 2/2] doc-rst: Programmatically render MAINTAINERS into ReST Kees Cook
2019-10-01 14:31 ` [PATCH 0/2] docs: " Jonathan Corbet
2019-10-01 15:09 ` Mauro Carvalho Chehab
2019-10-01 16:16 ` Kees Cook
2019-10-01 17:05 ` Jonathan Corbet
2019-10-01 17:35 ` Jonathan Corbet
2019-10-01 18:26 ` Kees Cook
2019-10-01 16:27 ` Kees Cook
2019-10-01 17:36 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001113629.6cdb1abb@lwn.net \
--to=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).