From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org, peterhuewe@gmx.de,
jgg@ziepe.ca, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@microsoft.com, thiruan@microsoft.com,
bryankel@microsoft.com, tee-dev@lists.linaro.org,
ilias.apalodimas@linaro.org, sumit.garg@linaro.org,
rdunlap@infradead.org
Subject: Re: [PATCH v2] tpm/tpm_ftpm_tee: add shutdown call back
Date: Wed, 16 Oct 2019 18:12:46 +0300 [thread overview]
Message-ID: <20191016151246.GA4261@linux.intel.com> (raw)
In-Reply-To: <20191014202135.429009-1-pasha.tatashin@soleen.com>
On Mon, Oct 14, 2019 at 04:21:35PM -0400, Pavel Tatashin wrote:
> add shutdown call back to close existing session with fTPM TA
> to support kexec scenario.
Sentences start in English with a capital letter :-)
>
> Signed-off-by: Thirupathaiah Annapureddy <thiruan@microsoft.com>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> ---
> drivers/char/tpm/tpm_ftpm_tee.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 6640a14dbe48..ad16ea555e97 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -328,6 +328,19 @@ static int ftpm_tee_remove(struct platform_device *pdev)
> return 0;
> }
>
> +/**
> + * ftpm_tee_shutdown - shutdown the TPM device
A function name has to have parentheses in kdoc. I know this not
consistently done in the subsystem ATM but this is what is documented
here:
https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt
/Jarkko
next prev parent reply other threads:[~2019-10-16 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 20:21 [PATCH v2] tpm/tpm_ftpm_tee: add shutdown call back Pavel Tatashin
2019-10-16 15:12 ` Jarkko Sakkinen [this message]
2019-10-16 16:31 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016151246.GA4261@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=bryankel@microsoft.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=peterhuewe@gmx.de \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).