* [PATCH] platform: goldfish: pipe: switch to platform_get_irq
2019-12-29 10:43 [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Yangtao Li
@ 2019-12-29 10:43 ` Yangtao Li
2019-12-29 10:44 ` Frank Lee
2019-12-29 10:43 ` [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache() Yangtao Li
2019-12-29 12:11 ` [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Bartosz Golaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Yangtao Li @ 2019-12-29 10:43 UTC (permalink / raw)
To: corbet, gregkh, bgolaszewski, arnd, sboyd, mchehab+samsung,
matti.vaittinen, phil.edworthy, suzuki.poulose, saravanak,
heikki.krogerus, dan.j.williams, joe, jeffrey.t.kirsher, mans,
tglx, hdegoede, akpm, ulf.hansson, ztuowen, sergei.shtylyov,
linux-doc, linux-kernel
Cc: Yangtao Li
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index cef0133aa47a..a1ebaec6eea9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
return -EINVAL;
}
- r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!r)
- return -EINVAL;
-
- dev->irq = r->start;
+ dev->irq = platform_get_irq(pdev, 0);
+ if (dev->irq < 0)
+ return dev->irq;
/*
* Exchange the versions with the host device
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] platform: goldfish: pipe: switch to platform_get_irq
2019-12-29 10:43 ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
@ 2019-12-29 10:44 ` Frank Lee
0 siblings, 0 replies; 8+ messages in thread
From: Frank Lee @ 2019-12-29 10:44 UTC (permalink / raw)
To: Jonathan Corbet, Greg Kroah-Hartman, bgolaszewski, Arnd Bergmann,
Stephen Boyd, Mauro Carvalho Chehab, matti.vaittinen,
phil.edworthy, suzuki.poulose, saravanak, heikki.krogerus,
dan.j.williams, Joe Perches, jeffrey.t.kirsher, mans, tglx,
hdegoede, Andrew Morton, Ulf Hansson, ztuowen, sergei.shtylyov,
linux-doc, Linux Kernel Mailing List
Ignore this, I posted it just now...
On Sun, Dec 29, 2019 at 6:43 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index cef0133aa47a..a1ebaec6eea9 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!r)
> - return -EINVAL;
> -
> - dev->irq = r->start;
> + dev->irq = platform_get_irq(pdev, 0);
> + if (dev->irq < 0)
> + return dev->irq;
>
> /*
> * Exchange the versions with the host device
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache()
2019-12-29 10:43 [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Yangtao Li
2019-12-29 10:43 ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
@ 2019-12-29 10:43 ` Yangtao Li
2019-12-29 12:12 ` Bartosz Golaszewski
2019-12-29 12:11 ` [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Bartosz Golaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Yangtao Li @ 2019-12-29 10:43 UTC (permalink / raw)
To: corbet, gregkh, bgolaszewski, arnd, sboyd, mchehab+samsung,
matti.vaittinen, phil.edworthy, suzuki.poulose, saravanak,
heikki.krogerus, dan.j.williams, joe, jeffrey.t.kirsher, mans,
tglx, hdegoede, akpm, ulf.hansson, ztuowen, sergei.shtylyov,
linux-doc, linux-kernel
Cc: Yangtao Li
Provide a nocache variant of devm_platform_ioremap_resource().
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
.../driver-api/driver-model/devres.rst | 1 +
drivers/base/platform.c | 19 +++++++++++++++++++
include/linux/platform_device.h | 3 +++
3 files changed, 23 insertions(+)
diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
index af1b1b9e3a17..3b79a3207490 100644
--- a/Documentation/driver-api/driver-model/devres.rst
+++ b/Documentation/driver-api/driver-model/devres.rst
@@ -320,6 +320,7 @@ IOMAP
devm_ioremap_resource_nocache()
devm_ioremap_resource_wc()
devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device
+ devm_platform_ioremap_resource_nocache()
devm_platform_ioremap_resource_wc()
devm_platform_ioremap_resource_byname()
devm_iounmap()
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index cf6b6b722e5c..80f420b9b4d7 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -79,6 +79,25 @@ void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev,
}
EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource);
+/**
+ * devm_platform_ioremap_resource_nocache - nocache variant of
+ * devm_platform_ioremap_resource()
+ *
+ * @pdev: platform device to use both for memory resource lookup as well as
+ * resource management
+ * @index: resource index
+ */
+void __iomem *
+devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
+ unsigned int index)
+{
+ struct resource *res;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, index);
+ return devm_ioremap_resource_nocache(&pdev->dev, res);
+}
+EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource_nocache);
+
/**
* devm_platform_ioremap_resource_wc - write-combined variant of
* devm_platform_ioremap_resource()
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 276a03c24691..b803e670b1c5 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -58,6 +58,9 @@ extern void __iomem *
devm_platform_ioremap_resource(struct platform_device *pdev,
unsigned int index);
extern void __iomem *
+devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
+ unsigned int index);
+extern void __iomem *
devm_platform_ioremap_resource_wc(struct platform_device *pdev,
unsigned int index);
extern void __iomem *
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache()
2019-12-29 10:43 ` [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache() Yangtao Li
@ 2019-12-29 12:12 ` Bartosz Golaszewski
0 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2019-12-29 12:12 UTC (permalink / raw)
To: Yangtao Li
Cc: Jonathan Corbet, Greg KH, Arnd Bergmann, Stephen Boyd,
Mauro Carvalho Chehab, Matti Vaittinen, Phil Edworthy,
suzuki.poulose, saravanak, Heikki Krogerus, dan.j.williams,
Joe Perches, Jeff Kirsher, mans, Thomas Gleixner, hdegoede,
Andrew Morton, ulf.hansson, ztuowen, Sergei Shtylyov, linux-doc,
LKML
niedz., 29 gru 2019 o 11:43 Yangtao Li <tiny.windzz@gmail.com> napisał(a):
>
> Provide a nocache variant of devm_platform_ioremap_resource().
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> .../driver-api/driver-model/devres.rst | 1 +
> drivers/base/platform.c | 19 +++++++++++++++++++
> include/linux/platform_device.h | 3 +++
> 3 files changed, 23 insertions(+)
>
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index af1b1b9e3a17..3b79a3207490 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -320,6 +320,7 @@ IOMAP
> devm_ioremap_resource_nocache()
> devm_ioremap_resource_wc()
> devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device
> + devm_platform_ioremap_resource_nocache()
> devm_platform_ioremap_resource_wc()
> devm_platform_ioremap_resource_byname()
> devm_iounmap()
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index cf6b6b722e5c..80f420b9b4d7 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -79,6 +79,25 @@ void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev,
> }
> EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource);
>
> +/**
> + * devm_platform_ioremap_resource_nocache - nocache variant of
> + * devm_platform_ioremap_resource()
> + *
> + * @pdev: platform device to use both for memory resource lookup as well as
> + * resource management
> + * @index: resource index
> + */
> +void __iomem *
> +devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
> + unsigned int index)
> +{
> + struct resource *res;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, index);
> + return devm_ioremap_resource_nocache(&pdev->dev, res);
> +}
> +EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource_nocache);
> +
> /**
> * devm_platform_ioremap_resource_wc - write-combined variant of
> * devm_platform_ioremap_resource()
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..b803e670b1c5 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -58,6 +58,9 @@ extern void __iomem *
> devm_platform_ioremap_resource(struct platform_device *pdev,
> unsigned int index);
> extern void __iomem *
> +devm_platform_ioremap_resource_nocache(struct platform_device *pdev,
> + unsigned int index);
> +extern void __iomem *
> devm_platform_ioremap_resource_wc(struct platform_device *pdev,
> unsigned int index);
> extern void __iomem *
> --
> 2.17.1
>
Please see my response to patch 1/2.
Bart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache()
2019-12-29 10:43 [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Yangtao Li
2019-12-29 10:43 ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
2019-12-29 10:43 ` [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache() Yangtao Li
@ 2019-12-29 12:11 ` Bartosz Golaszewski
2019-12-29 14:36 ` Frank Lee
2 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2019-12-29 12:11 UTC (permalink / raw)
To: Yangtao Li
Cc: Jonathan Corbet, Greg KH, Arnd Bergmann, Stephen Boyd,
Mauro Carvalho Chehab, Matti Vaittinen, Phil Edworthy,
suzuki.poulose, saravanak, Heikki Krogerus, dan.j.williams,
Joe Perches, Jeff Kirsher, mans, Thomas Gleixner, hdegoede,
Andrew Morton, ulf.hansson, ztuowen, Sergei Shtylyov, linux-doc,
LKML
niedz., 29 gru 2019 o 11:43 Yangtao Li <tiny.windzz@gmail.com> napisał(a):
>
> Provide a variant of devm_ioremap_resource() for nocache ioremap.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Documentation/driver-api/driver-model/devres.rst | 1 +
> include/linux/device.h | 2 ++
> lib/devres.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index 13046fcf0a5d..af1b1b9e3a17 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -317,6 +317,7 @@ IOMAP
> devm_ioremap_uc()
> devm_ioremap_wc()
> devm_ioremap_resource() : checks resource, requests memory region, ioremaps
> + devm_ioremap_resource_nocache()
> devm_ioremap_resource_wc()
> devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device
> devm_platform_ioremap_resource_wc()
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 96ff76731e93..3aa353aa52e2 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);
>
> void __iomem *devm_ioremap_resource(struct device *dev,
> const struct resource *res);
> +void __iomem *devm_ioremap_resource_nocache(struct device *dev,
> + const struct resource *res);
> void __iomem *devm_ioremap_resource_wc(struct device *dev,
> const struct resource *res);
>
> diff --git a/lib/devres.c b/lib/devres.c
> index f56070cf970b..a182f8479fbf 100644
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev,
> }
> EXPORT_SYMBOL(devm_ioremap_resource);
>
> +/**
> + * devm_ioremap_resource_nocache() - nocache variant of
> + * devm_ioremap_resource()
> + * @dev: generic device to handle the resource for
> + * @res: resource to be handled
> + *
> + * Returns a pointer to the remapped memory or an ERR_PTR() encoded error code
> + * on failure.
> + */
> +void __iomem *devm_ioremap_resource_nocache(struct device *dev,
> + const struct resource *res)
> +{
> + return __devm_ioremap_resource(dev, res, DEVM_IOREMAP_NC);
> +}
> +
> /**
> * devm_ioremap_resource_wc() - write-combined variant of
> * devm_ioremap_resource()
> --
> 2.17.1
>
This has been discussed before. The nocache variants of ioremap() are
being phased out as they're only ever needed on one obscure
architecture IIRC. This is not needed, rather we should convert all
nocache calls to regular ioremap().
Bart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache()
2019-12-29 12:11 ` [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Bartosz Golaszewski
@ 2019-12-29 14:36 ` Frank Lee
2019-12-29 15:04 ` Arnd Bergmann
0 siblings, 1 reply; 8+ messages in thread
From: Frank Lee @ 2019-12-29 14:36 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Jonathan Corbet, Greg KH, Arnd Bergmann, Stephen Boyd,
Mauro Carvalho Chehab, Matti Vaittinen, Phil Edworthy,
suzuki.poulose, saravanak, Heikki Krogerus, dan.j.williams,
Joe Perches, Jeff Kirsher, mans, Thomas Gleixner, hdegoede,
Andrew Morton, Ulf Hansson, ztuowen, Sergei Shtylyov, linux-doc,
LKML
On Sun, Dec 29, 2019 at 8:11 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> niedz., 29 gru 2019 o 11:43 Yangtao Li <tiny.windzz@gmail.com> napisał(a):
> >
> > Provide a variant of devm_ioremap_resource() for nocache ioremap.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Documentation/driver-api/driver-model/devres.rst | 1 +
> > include/linux/device.h | 2 ++
> > lib/devres.c | 15 +++++++++++++++
> > 3 files changed, 18 insertions(+)
> >
> > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> > index 13046fcf0a5d..af1b1b9e3a17 100644
> > --- a/Documentation/driver-api/driver-model/devres.rst
> > +++ b/Documentation/driver-api/driver-model/devres.rst
> > @@ -317,6 +317,7 @@ IOMAP
> > devm_ioremap_uc()
> > devm_ioremap_wc()
> > devm_ioremap_resource() : checks resource, requests memory region, ioremaps
> > + devm_ioremap_resource_nocache()
> > devm_ioremap_resource_wc()
> > devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device
> > devm_platform_ioremap_resource_wc()
> > diff --git a/include/linux/device.h b/include/linux/device.h
> > index 96ff76731e93..3aa353aa52e2 100644
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);
> >
> > void __iomem *devm_ioremap_resource(struct device *dev,
> > const struct resource *res);
> > +void __iomem *devm_ioremap_resource_nocache(struct device *dev,
> > + const struct resource *res);
> > void __iomem *devm_ioremap_resource_wc(struct device *dev,
> > const struct resource *res);
> >
> > diff --git a/lib/devres.c b/lib/devres.c
> > index f56070cf970b..a182f8479fbf 100644
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> > @@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev,
> > }
> > EXPORT_SYMBOL(devm_ioremap_resource);
> >
> > +/**
> > + * devm_ioremap_resource_nocache() - nocache variant of
> > + * devm_ioremap_resource()
> > + * @dev: generic device to handle the resource for
> > + * @res: resource to be handled
> > + *
> > + * Returns a pointer to the remapped memory or an ERR_PTR() encoded error code
> > + * on failure.
> > + */
> > +void __iomem *devm_ioremap_resource_nocache(struct device *dev,
> > + const struct resource *res)
> > +{
> > + return __devm_ioremap_resource(dev, res, DEVM_IOREMAP_NC);
> > +}
> > +
> > /**
> > * devm_ioremap_resource_wc() - write-combined variant of
> > * devm_ioremap_resource()
> > --
> > 2.17.1
> >
>
> This has been discussed before. The nocache variants of ioremap() are
> being phased out as they're only ever needed on one obscure
> architecture IIRC. This is not needed, rather we should convert all
> nocache calls to regular ioremap().
Thanks for pointing out!
I have seen the use of ioremap_nocache in many architectures,
so they are wrong and should be changed to ioremap?
Yangtao
>
> Bart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache()
2019-12-29 14:36 ` Frank Lee
@ 2019-12-29 15:04 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2019-12-29 15:04 UTC (permalink / raw)
To: Frank Lee
Cc: Bartosz Golaszewski, Jonathan Corbet, Greg KH, Stephen Boyd,
Mauro Carvalho Chehab, Matti Vaittinen, Phil Edworthy,
Suzuki K Poulose, saravanak, Heikki Krogerus, Dan Williams,
Joe Perches, Jeff Kirsher, Mans Rullgard, Thomas Gleixner,
Hans de Goede, Andrew Morton, Ulf Hansson, Tuowen Zhao,
Sergei Shtylyov, linux-doc, LKML
On Sun, Dec 29, 2019 at 3:36 PM Frank Lee <tiny.windzz@gmail.com> wrote:
> Thanks for pointing out!
> I have seen the use of ioremap_nocache in many architectures,
> so they are wrong and should be changed to ioremap?
Yes, those patches are already part of linux-next.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread