linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yangtao Li <tiny.windzz@gmail.com>
To: corbet@lwn.net, gregkh@linuxfoundation.org,
	bgolaszewski@baylibre.com, arnd@arndb.de, sboyd@kernel.org,
	mchehab+samsung@kernel.org, matti.vaittinen@fi.rohmeurope.com,
	phil.edworthy@renesas.com, suzuki.poulose@arm.com,
	saravanak@google.com, heikki.krogerus@linux.intel.com,
	dan.j.williams@intel.com, joe@perches.com,
	jeffrey.t.kirsher@intel.com, mans@mansr.com, tglx@linutronix.de,
	hdegoede@redhat.com, akpm@linux-foundation.org,
	ulf.hansson@linaro.org, ztuowen@gmail.com,
	sergei.shtylyov@cogentembedded.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH] platform: goldfish: pipe: switch to platform_get_irq
Date: Sun, 29 Dec 2019 10:43:24 +0000	[thread overview]
Message-ID: <20191229104325.10132-2-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20191229104325.10132-1-tiny.windzz@gmail.com>

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index cef0133aa47a..a1ebaec6eea9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
-		return -EINVAL;
-
-	dev->irq = r->start;
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
+		return dev->irq;
 
 	/*
 	 * Exchange the versions with the host device
-- 
2.17.1


  reply	other threads:[~2019-12-29 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 10:43 [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Yangtao Li
2019-12-29 10:43 ` Yangtao Li [this message]
2019-12-29 10:44   ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Frank Lee
2019-12-29 10:43 ` [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache() Yangtao Li
2019-12-29 12:12   ` Bartosz Golaszewski
2019-12-29 12:11 ` [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Bartosz Golaszewski
2019-12-29 14:36   ` Frank Lee
2019-12-29 15:04     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229104325.10132-2-tiny.windzz@gmail.com \
    --to=tiny.windzz@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=ztuowen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).