From: Greg KH <greg@kroah.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: brendanhiggins@google.com, corbet@lwn.net,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH kunit 1/3] kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display
Date: Thu, 23 Jan 2020 15:55:26 +0100 [thread overview]
Message-ID: <20200123145526.GB1687563@kroah.com> (raw)
In-Reply-To: <1579790840-27009-2-git-send-email-alan.maguire@oracle.com>
On Thu, Jan 23, 2020 at 02:47:18PM +0000, Alan Maguire wrote:
> +int debugfs_init(void)
> +{
> + if (!debugfs_rootdir)
> + debugfs_rootdir = debugfs_create_dir(KUNIT_DEBUGFS_ROOT, NULL);
> + if (IS_ERR(debugfs_rootdir))
> + return PTR_ERR(debugfs_rootdir);
> + return 0;
No, you never care if a debugfs call works or not, just call it and move
on. So just create the directory, and then pass it into whatever
debugfs call you want, never test it or do anything about it. This
function can be void as well.
> +void debugfs_create_suite(struct kunit_suite *suite)
> +{
> + /* First add /sys/kernel/debug/kunit/<testsuite> */
> + suite->debugfs = debugfs_create_dir(suite->name, debugfs_rootdir);
> + if (IS_ERR(suite->debugfs))
> + return;
Same here, don't test, just call and move on.
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-23 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 14:47 [PATCH kunit 0/3] kunit: add debugfs representation to show results/run tests Alan Maguire
2020-01-23 14:47 ` [PATCH kunit 1/3] kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display Alan Maguire
2020-01-23 14:53 ` Greg KH
2020-01-23 14:55 ` Greg KH [this message]
2020-01-23 14:47 ` [PATCH kunit 2/3] kunit: add "run" debugfs file to run suites, display results Alan Maguire
2020-01-23 14:47 ` [PATCH kunit 3/3] kunit: update documentation to describe debugfs representation Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123145526.GB1687563@kroah.com \
--to=greg@kroah.com \
--cc=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox