From: Jonathan Corbet <corbet@lwn.net>
To: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
swood@redhat.com, mcgrof@kernel.org, keescook@chromium.org,
yzaikin@google.com, mingo@kernel.org, kernel@gpiccoli.net
Subject: Re: [PATCH] Documentation: Better document the softlockup_panic sysctl
Date: Tue, 10 Mar 2020 11:05:54 -0600 [thread overview]
Message-ID: <20200310110554.1fc016ad@lwn.net> (raw)
In-Reply-To: <20200310151503.11589-1-gpiccoli@canonical.com>
On Tue, 10 Mar 2020 12:15:03 -0300
"Guilherme G. Piccoli" <gpiccoli@canonical.com> wrote:
> Commit 9c44bc03fff4 ("softlockup: allow panic on lockup") added the
> softlockup_panic sysctl, but didn't add information about it to the file
> Documentation/admin-guide/sysctl/kernel.rst (which in that time certainly
> wasn't rst and had other name!).
>
> This patch just adds the respective documentation and references it from
> the corresponding entry in Documentation/admin-guide/kernel-parameters.txt.
>
> This patch was strongly based on Scott Wood's commit d22881dc13b6
> ("Documentation: Better document the hardlockup_panic sysctl").
>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
So this doesn't even come close to applying; could you respin it against
docs-next, please?
> Documentation/admin-guide/kernel-parameters.txt | 6 +++---
> Documentation/admin-guide/sysctl/kernel.rst | 13 +++++++++++++
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index c07815d230bc..adf77ead02c3 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4515,9 +4515,9 @@
>
> A nonzero value instructs the soft-lockup detector
> to panic the machine when a soft-lockup occurs. This
> - is also controlled by CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC
> - which is the respective build-time switch to that
> - functionality.
> + is also controlled by kernel.softlockup_panic sysctl
..and while you're at it, make it "*the* kernel.softlockup_panic sysctl" :)
Thanks,
jon
next prev parent reply other threads:[~2020-03-10 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 15:15 [PATCH] Documentation: Better document the softlockup_panic sysctl Guilherme G. Piccoli
2020-03-10 16:03 ` Kees Cook
2020-03-10 17:05 ` Jonathan Corbet [this message]
2020-03-10 18:20 ` Guilherme Piccoli
2020-03-10 18:49 ` Jonathan Corbet
2020-03-10 19:04 ` Guilherme Piccoli
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 19:18 Guilherme G. Piccoli
2020-03-19 19:33 ` Guilherme Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310110554.1fc016ad@lwn.net \
--to=corbet@lwn.net \
--cc=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=swood@redhat.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).