Re: [PATCH]Documentation/filesystems/tranlastions : translate debugfs.txt into Chinese

Re: [PATCH]Documentation/filesystems/tranlastions : translate debugfs.txt into Chinese

[Jonathan Corbet]

On Wed, 11 Mar 2020 09:21:15 +0800 (GMT+08:00)
罗楚成 <luochucheng@vivo.com> wrote:

> docs/zh_CN: translate Documentaion/filesystems/debugfs.txt to Chinese.
> 
> 
> Since debugfs is widely used in kernel development to help developers to debug their
> new features, it's necessary to translate it into Chinese to make debug easier for
> Chinese developers.
> 
> 
> Signed-off-by: luochucheng<luochucheng@vivo.com>

You did not read the message I sent you last time.  So I will repeat:

 - How are you generating this patch?  You should be using git
   format-patch, which should be generating a diffstat (which is missing).

 - You need to add this file to index.rst so it becomes part of the docs
   build.

 - Please put your proper name in the signed-off-by line

 - Please fix the white-space issues that wreck the code samples in your
   translated document.

Additionally, sending the patch without trivial typos (i.e. misspelled
directory names) in the changelog would be appreciated.

Thank you,

jon

Re: [PATCH]Documentation/filesystems/tranlastions : translate debugfs.txt into Chinese

[Jonathan Corbet]

On Tue, 10 Mar 2020 16:48:24 +0800 (GMT+08:00)
罗楚成 <luochucheng@vivo.com> wrote:

> I 've sent the last email with wrong topic, this one is to fix it.

When something like that happens, please just resend the patch with the
correction applied, rather than forwarding it like this.  That way you
don't force maintainers 

> From: "罗楚成" <luochucheng@vivo.com>
> Date: 2020-03-10 16:43:27
> To: corbet@lwn.net
> Cc: "王文虎" <wenhu.wang@vivo.com>,tekkamanninja@gmail.com,harryxiyou@gmail.com,mamurph@cs.clemson.edu,linux-kernel@zh-kernel.org,linux-doc@vger.kernel.org
> Subject: [PATCH] arch_arm64_ fix typo in a comment.eml
> docs/zh_CN: translate Documentaion/filesystems/debugfs.txt to Chinese.
> 
> 
> Since debugfs is widely used in kernel development to help developers to debug their
> new features, it's necessary to translate it into Chinese to make debug easier for
> Chinese developers.
> 
> 
> Signed-off-by: luochucheng<luochucheng@vivo.com>

Also, while you're at it, a few other things:

 - Please put your full proper name in the signoff line, rather than just
   an account name.

 - The patch should have a diffstat showing what files you have touched;
   "git format-patch" should create that for you.

 - You need to add this file to the relevant index.rst file so that it is
   included in the docs build.

 - There appears to be some white-space damage in the patch; look at the
   code samples in particular.

Could you fix those things up and resubmit, please?

Thanks,

jon