* [PATCH] scripts: documentation-file-ref-check: Add line break before exit
@ 2020-04-14 9:41 Tiezhu Yang
2020-04-14 16:49 ` Mauro Carvalho Chehab
2020-04-15 21:13 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-04-14 9:41 UTC (permalink / raw)
To: Jonathan Corbet, Mauro Carvalho Chehab
Cc: linux-doc, linux-kernel, Xuefeng Li
If execute ./scripts/documentation-file-ref-check in a directory which is
not a git tree, it will exit without a line break, fix it.
Without this patch:
[loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$
With this patch:
[loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
Warning: can't check if file exists, as this is not a git tree
[loongson@localhost linux-5.7-rc1]$
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
scripts/documentation-file-ref-check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
index 9a8cc10..c71832b 100755
--- a/scripts/documentation-file-ref-check
+++ b/scripts/documentation-file-ref-check
@@ -25,7 +25,7 @@ my $fix = 0;
my $warn = 0;
if (! -d ".git") {
- printf "Warning: can't check if file exists, as this is not a git tree";
+ printf "Warning: can't check if file exists, as this is not a git tree\n";
exit 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts: documentation-file-ref-check: Add line break before exit
2020-04-14 9:41 [PATCH] scripts: documentation-file-ref-check: Add line break before exit Tiezhu Yang
@ 2020-04-14 16:49 ` Mauro Carvalho Chehab
2020-04-15 21:13 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2020-04-14 16:49 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: Jonathan Corbet, linux-doc, linux-kernel, Xuefeng Li
Em Tue, 14 Apr 2020 17:41:48 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> escreveu:
> If execute ./scripts/documentation-file-ref-check in a directory which is
> not a git tree, it will exit without a line break, fix it.
>
> Without this patch:
>
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$
>
> With this patch:
>
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree
> [loongson@localhost linux-5.7-rc1]$
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> scripts/documentation-file-ref-check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index 9a8cc10..c71832b 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -25,7 +25,7 @@ my $fix = 0;
> my $warn = 0;
>
> if (! -d ".git") {
> - printf "Warning: can't check if file exists, as this is not a git tree";
> + printf "Warning: can't check if file exists, as this is not a git tree\n";
> exit 0;
> }
>
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts: documentation-file-ref-check: Add line break before exit
2020-04-14 9:41 [PATCH] scripts: documentation-file-ref-check: Add line break before exit Tiezhu Yang
2020-04-14 16:49 ` Mauro Carvalho Chehab
@ 2020-04-15 21:13 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2020-04-15 21:13 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: Mauro Carvalho Chehab, linux-doc, linux-kernel, Xuefeng Li
On Tue, 14 Apr 2020 17:41:48 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> If execute ./scripts/documentation-file-ref-check in a directory which is
> not a git tree, it will exit without a line break, fix it.
>
> Without this patch:
>
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree[loongson@localhost linux-5.7-rc1]$
>
> With this patch:
>
> [loongson@localhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree
> [loongson@localhost linux-5.7-rc1]$
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-15 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-14 9:41 [PATCH] scripts: documentation-file-ref-check: Add line break before exit Tiezhu Yang
2020-04-14 16:49 ` Mauro Carvalho Chehab
2020-04-15 21:13 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).