From: Andi Kleen <ak@linux.intel.com>
To: John Haxby <john.haxby@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] x86/fpu: Allow clearcpuid= to clear several bits
Date: Wed, 22 Apr 2020 18:41:37 -0700 [thread overview]
Message-ID: <20200423014137.GM608746@tassilo.jf.intel.com> (raw)
In-Reply-To: <96EA2DF4-7490-4FF0-BB3E-EC9157517918@oracle.com>
>
> I did wonder about that. However, cmdline_find_option() is specifically documented as
>
> * Find a non-boolean option (i.e. option=argument). In accordance with
> * standard Linux practice, if this option is repeated, this returns the
> * last instance on the command line.
Okay so would need a special version that uses the first and an option
to pass the cmdline string.
>
> And since that appeared in 2017 I decided to stick with the new-fangled interface :) This is a little-used feature; I'm not sure it's worth the effort of parsing the command line for the old style. What do you think?
I'm not sure it's that little used. We use it quite a bit for testing
and workarounds, and it might be that some of those are deployed.
-Andi
prev parent reply other threads:[~2020-04-23 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:03 [PATCH 0/1] x86/fpu: Allow clearcpuid= to clear several bits John Haxby
2020-04-22 12:03 ` [PATCH 1/1] " John Haxby
2020-04-22 14:35 ` Andi Kleen
2020-04-22 15:21 ` John Haxby
2020-04-23 1:41 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423014137.GM608746@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=john.haxby@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).