From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Joshua Abraham <j.abraham1776@gmail.com>
Cc: pbonzini@redhat.com, corbet@lwn.net, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: kvm: Fix KVM_KVMCLOCK_CTRL API doc
Date: Fri, 1 May 2020 14:38:03 -0700 [thread overview]
Message-ID: <20200501213803.GF4760@linux.intel.com> (raw)
In-Reply-To: <20200501211040.GA22118@josh-ZenBook>
On Fri, May 01, 2020 at 05:10:40PM -0400, Joshua Abraham wrote:
> On Fri, May 01, 2020 at 01:51:06PM -0700, Sean Christopherson wrote:
> > I don't disagree, but simply doing s/host/guest yields a misleading
> > sentence and inconsistencies with the rest of the paragraph.
>
> I see your point. Would this wording be clearer:
>
> "This ioctl sets a flag accessible to the guest indicating that it has been
> paused from the host userspace.
Ya. Minor nit, probably worth clarifying that 'it' refers to the vCPU, e.g.
This ioctl sets a flag accessible to the guest indicating that the specified
vCPU has been paused by the host userspace.
>
> The host will set a flag in the pvclock structure that is checked
> from the soft lockup watchdog. The flag is part of the pvclock structure that
> is shared between guest and host, specifically the second bit of the flags
> field of the pvclock_vcpu_time_info structure. It will be set exclusively by
> the host and read/cleared exclusively by the guest. The guest operation of
> checking and clearing the flag must be an atomic operation so
> load-link/store-conditional, or equivalent must be used. There are two cases
> where the guest will clear the flag: when the soft lockup watchdog timer resets
> itself or when a soft lockup is detected. This ioctl can be called any time
> after pausing the vcpu, but before it is resumed."
prev parent reply other threads:[~2020-05-01 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:34 [PATCH] docs: kvm: Fix KVM_KVMCLOCK_CTRL API doc Joshua Abraham
2020-05-01 20:18 ` Sean Christopherson
2020-05-01 20:32 ` Joshua Abraham
2020-05-01 20:51 ` Sean Christopherson
2020-05-01 21:10 ` Joshua Abraham
2020-05-01 21:38 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501213803.GF4760@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=corbet@lwn.net \
--cc=j.abraham1776@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).