* [PATCH] zswap: docs/vm: Fix typo accept_threshold_percent in zswap.rst
@ 2020-06-01 0:44 Sedat Dilek
0 siblings, 0 replies; 3+ messages in thread
From: Sedat Dilek @ 2020-06-01 0:44 UTC (permalink / raw)
To: Jonathan Corbet, Andrew Morton, Vitaly Wool, Maciej S. Szmigiero,
linux-doc, inux-kernel
Cc: Sedat Dilek
Recently, I switched over from swap-file to zramswap.
When reading the Documentation/vm/zswap.rst file I fell over this typo.
The parameter is called accept_threshold_percent not accept_threhsold_percent
in /sys/module/zswap/parameters/ directory.
Fixes: 45190f01dd402 ("mm/zswap.c: add allocation hysteresis if pool limit is hit")
Cc: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
Documentation/vm/zswap.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/vm/zswap.rst b/Documentation/vm/zswap.rst
index f8c6a79d7c70..d8d9fa4a1f0d 100644
--- a/Documentation/vm/zswap.rst
+++ b/Documentation/vm/zswap.rst
@@ -140,10 +140,10 @@ without any real benefit but with a performance drop for the system), a
special parameter has been introduced to implement a sort of hysteresis to
refuse taking pages into zswap pool until it has sufficient space if the limit
has been hit. To set the threshold at which zswap would start accepting pages
-again after it became full, use the sysfs ``accept_threhsold_percent``
+again after it became full, use the sysfs ``accept_threshold_percent``
attribute, e. g.::
- echo 80 > /sys/module/zswap/parameters/accept_threhsold_percent
+ echo 80 > /sys/module/zswap/parameters/accept_threshold_percent
Setting this parameter to 100 will disable the hysteresis.
--
2.27.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] zswap: docs/vm: Fix typo accept_threshold_percent in zswap.rst
@ 2020-06-01 0:59 Sedat Dilek
2020-06-01 15:34 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2020-06-01 0:59 UTC (permalink / raw)
To: Jonathan Corbet, Andrew Morton, Vitaly Wool, Maciej S. Szmigiero,
linux-doc, linux-kernel
Cc: Sedat Dilek
Recently, I switched over from swap-file to zramswap.
When reading the Documentation/vm/zswap.rst file I fell over this typo.
The parameter is called accept_threshold_percent not accept_threhsold_percent
in /sys/module/zswap/parameters/ directory.
Fixes: 45190f01dd402 ("mm/zswap.c: add allocation hysteresis if pool limit is hit")
Cc: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
Changes v1->v2:
- Changed subject line
- Resend to LKML with correct email-address
Documentation/vm/zswap.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/vm/zswap.rst b/Documentation/vm/zswap.rst
index f8c6a79d7c70..d8d9fa4a1f0d 100644
--- a/Documentation/vm/zswap.rst
+++ b/Documentation/vm/zswap.rst
@@ -140,10 +140,10 @@ without any real benefit but with a performance drop for the system), a
special parameter has been introduced to implement a sort of hysteresis to
refuse taking pages into zswap pool until it has sufficient space if the limit
has been hit. To set the threshold at which zswap would start accepting pages
-again after it became full, use the sysfs ``accept_threhsold_percent``
+again after it became full, use the sysfs ``accept_threshold_percent``
attribute, e. g.::
- echo 80 > /sys/module/zswap/parameters/accept_threhsold_percent
+ echo 80 > /sys/module/zswap/parameters/accept_threshold_percent
Setting this parameter to 100 will disable the hysteresis.
--
2.27.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] zswap: docs/vm: Fix typo accept_threshold_percent in zswap.rst
2020-06-01 0:59 [PATCH] zswap: docs/vm: Fix typo accept_threshold_percent in zswap.rst Sedat Dilek
@ 2020-06-01 15:34 ` Jonathan Corbet
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2020-06-01 15:34 UTC (permalink / raw)
To: Sedat Dilek
Cc: Andrew Morton, Vitaly Wool, Maciej S. Szmigiero, linux-doc,
linux-kernel
On Mon, 1 Jun 2020 02:59:11 +0200
Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Recently, I switched over from swap-file to zramswap.
>
> When reading the Documentation/vm/zswap.rst file I fell over this typo.
>
> The parameter is called accept_threshold_percent not accept_threhsold_percent
> in /sys/module/zswap/parameters/ directory.
>
> Fixes: 45190f01dd402 ("mm/zswap.c: add allocation hysteresis if pool limit is hit")
> Cc: Vitaly Wool <vitaly.wool@konsulko.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Applied, thanks.
> Changes v1->v2:
> - Changed subject line
> - Resend to LKML with correct email-address
When you make a v2 like this, it's helpful if you mark it as "[PATCH v2]".
I had three versions of this in my inbox and had to figure out what was
going on...
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-01 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-01 0:59 [PATCH] zswap: docs/vm: Fix typo accept_threshold_percent in zswap.rst Sedat Dilek
2020-06-01 15:34 ` Jonathan Corbet
-- strict thread matches above, loose matches on Subject: below --
2020-06-01 0:44 Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).