From: Mike Snitzer <snitzer@redhat.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: JeongHyeon Lee <jhs2.lee@samsung.com>,
dm-devel@redhat.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, agk@redhat.com, corbet@lwn.net
Subject: Re: New mode DM-Verity error handling
Date: Thu, 18 Jun 2020 13:09:52 -0400 [thread overview]
Message-ID: <20200618170952.GA18057@redhat.com> (raw)
In-Reply-To: <20200618165006.GA103290@google.com>
On Thu, Jun 18 2020 at 12:50pm -0400,
Sami Tolvanen <samitolvanen@google.com> wrote:
> On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote:
> > I do not accept that panicing the system because of verity failure is
> > reasonable.
> >
> > In fact, even rebooting (via DM_VERITY_MODE_RESTART) looks very wrong.
> >
> > The device should be put in a failed state and left for admin recovery.
>
> That's exactly how the restart mode works on some Android devices. The
> bootloader sees the verification error and puts the device in recovery
> mode. Using the restart mode on systems without firmware support won't
> make sense, obviously.
OK, so I need further justification from Samsung why they are asking for
this panic mode.
Thanks,
Mike
next prev parent reply other threads:[~2020-06-18 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200618070250epcas1p409eb2ddd19ecc5d55c219ac3dc884f25@epcas1p4.samsung.com>
2020-06-18 6:56 ` [patch] New mode DM-Verity error handling JeongHyeon Lee
2020-06-18 15:44 ` Mike Snitzer
2020-06-18 16:50 ` [dm-devel] " Sami Tolvanen
2020-06-18 17:09 ` Mike Snitzer [this message]
2020-06-22 0:27 ` JeongHyeon Lee
2020-06-22 7:58 ` Milan Broz
2020-06-22 23:53 ` JeongHyeon Lee
2020-06-23 7:28 ` Milan Broz
2020-06-23 8:08 ` JeongHyeon Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618170952.GA18057@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=corbet@lwn.net \
--cc=dm-devel@redhat.com \
--cc=jhs2.lee@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).