From: Matthew Wilcox <willy@infradead.org>
To: Danny Lin <danny@kdrag0n.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] editorconfig: Add automatic editor configuration file
Date: Fri, 3 Jul 2020 13:49:39 +0100 [thread overview]
Message-ID: <20200703124939.GG25523@casper.infradead.org> (raw)
In-Reply-To: <20200703073143.423557-1-danny@kdrag0n.dev>
On Fri, Jul 03, 2020 at 12:31:43AM -0700, Danny Lin wrote:
> +# This avoids introducing too many unnecessary changes in trivial commits
> +trim_trailing_whitespace = false
I think we prefer trailing whitespace to be trimmed, even for trivial commits.
> +# General 4-space files
> +[*.{pl,pm,py,tc,json,tc}]
> +indent_style = space
> +indent_size = 4
> +
> +# General 2-space files
> +[*.{rb,rst,yaml,cocci,xsl,svg,bconf,clang-format}]
> +indent_style = space
> +indent_size = 2
The rst files I've seen either use tabs or three spaces for indent.
Where did this 2 come from?
next prev parent reply other threads:[~2020-07-03 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 0:12 [PATCH] editorconfig: Add automatic editor configuration file Danny Lin
2020-07-03 5:38 ` Miguel Ojeda
2020-07-03 7:31 ` Danny Lin
2020-07-03 7:31 ` [PATCH v2] " Danny Lin
2020-07-03 12:29 ` Jonathan Corbet
2021-03-24 10:59 ` Rasmus Villemoes
2021-03-25 7:00 ` Masahiro Yamada
2021-03-25 9:44 ` Miguel Ojeda
2020-07-03 12:49 ` Matthew Wilcox [this message]
2020-07-03 17:22 ` Joe Perches
2020-07-03 7:49 ` [PATCH] " Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703124939.GG25523@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=danny@kdrag0n.dev \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox