From: Christoph Hellwig <hch@infradead.org>
To: Simon Arlott <simon@octiron.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@infradead.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Pavel Machek <pavel@ucw.cz>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [PATCH 2/2] x86/reboot/quirks: Add ASRock Z170 Extreme4
Date: Wed, 15 Jul 2020 19:12:44 +0100 [thread overview]
Message-ID: <20200715181244.GB17753@infradead.org> (raw)
In-Reply-To: <a7c26ca1-0201-7526-8b69-484868725ee3@0882a8b5-c6c3-11e9-b005-00805fc181fe>
On Mon, Jun 29, 2020 at 09:58:05PM +0100, Simon Arlott wrote:
> If a PCI mode reboot is performed on the ASRock Z170 Extreme4, a power
> cycle will occur. Automatically set the reboot quirk for this to prepare
> for the power off (i.e. stop all disks).
>
> This will only take effect if PCI mode is manually used. It'll be too late
> in the reboot process to prepare for power off if the other reboot methods
> fail.
>
> It is necessary to re-order the processing of DMI checks because this quirk
> must apply even if a reboot= command line parameter is used as that's the
> only way to specify a PCI mode reboot.
>
> Signed-off-by: Simon Arlott <simon@octiron.net>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-07-15 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:56 [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot Simon Arlott
2020-06-29 20:58 ` [PATCH 2/2] x86/reboot/quirks: Add ASRock Z170 Extreme4 Simon Arlott
2020-07-15 18:12 ` Christoph Hellwig [this message]
2020-07-15 18:11 ` [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot Christoph Hellwig
2020-07-15 20:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715181244.GB17753@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=bp@alien8.de \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jejb@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=simon@octiron.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).