linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	netdev@vger.kernel.org, davem@davemloft.net,
	richardcochran@gmail.com, sorganov@gmail.com, andrew@lunn.ch,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: networking: timestamping: replace tabs with spaces in code blocks
Date: Wed, 15 Jul 2020 20:29:00 +0100	[thread overview]
Message-ID: <20200715192900.GH12769@casper.infradead.org> (raw)
In-Reply-To: <20200715121717.41aaff49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Wed, Jul 15, 2020 at 12:17:17PM -0700, Jakub Kicinski wrote:
> On Thu,  9 Jul 2020 23:22:10 +0300 Vladimir Oltean wrote:
> > Reading the document in vim is currently not a pleasant experience. Its
> > rst syntax highlighting is confused by the "*/" sequences which it's not
> > interpreting as part of the code blocks for some reason.
> > 
> > Replace the tabs with spaces, so that syntax highlighters (at least the
> > one in vim) have a better idea where code blocks start and where they
> > end.
> > 
> > Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> 
> Dunno about this change, there seems to be plenty examples of using
> tabs for indentation of code block :(
> 
> Jon, any guidance? It seems to me the document renders correctly [1],
> so the onus is on the editor to fix the RST highlight..

vim's rst mode really really really wants to use spaces instead of tabs.
It's screwed me over a bunch of times, so I eventually just disabled it.
I think we should probably stop fighting it and use spaces in rst files
instead of tabs, but that's not my call to make.

      reply	other threads:[~2020-07-15 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200709202210.72985-1-olteanv@gmail.com>
2020-07-15 19:17 ` [PATCH net-next] docs: networking: timestamping: replace tabs with spaces in code blocks Jakub Kicinski
2020-07-15 19:29   ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200715192900.GH12769@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=andrew@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=sorganov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).