From: Richard Cochran <richardcochran@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
sorganov@gmail.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] docs: networking: timestamping: add a set of frequently asked questions
Date: Mon, 20 Jul 2020 17:21:50 -0700 [thread overview]
Message-ID: <20200721002150.GB21585@hoboy> (raw)
In-Reply-To: <20200720221314.xkdbw25nsjsyvgbv@skbuf>
On Tue, Jul 21, 2020 at 01:13:14AM +0300, Vladimir Oltean wrote:
> I think at least part of the reason why this keeps going on is that
> there aren't any hard and fast rules that say you shouldn't do it. When
> there isn't even a convincing percentage of DSA/PHY drivers that do set
> SKBTX_HW_TSTAMP, the chances are pretty low that you'll get a stacked
> PHC driver that sets the flag, plus a MAC driver that checks for it
> incorrectly. So people tend to ignore this case.
Right.
> Even though, if stacked
> DSA drivers started supporting software TX timestamping (which is not
> unlikely, given the fact that this would also give you compatibility
> with PHY timestamping), I'm sure things would change, because more
> people would become aware of the issue once mv88e6xxx starts getting
> affected.
I really can't see the utility in having a SW time stamp from a DSA
interface. The whole point of DSA time stamping is to get the ingress
and egress time of frames on the external ports, in order to correct
for the residence time within the switch.
Thanks,
Richard
next prev parent reply other threads:[~2020-07-21 0:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 16:10 [PATCH net-next 0/3] Document more PTP timestamping known quirks Vladimir Oltean
2020-07-17 16:10 ` [PATCH net-next 1/3] docs: networking: timestamping: rename last section to "Known bugs" Vladimir Oltean
2020-07-17 22:05 ` Jacob Keller
2020-07-17 16:10 ` [PATCH net-next 2/3] docs: networking: timestamping: add one more known issue Vladimir Oltean
2020-07-17 23:08 ` Jacob Keller
2020-07-18 11:36 ` Vladimir Oltean
2020-07-17 16:10 ` [PATCH net-next 3/3] docs: networking: timestamping: add a set of frequently asked questions Vladimir Oltean
2020-07-17 23:12 ` Jacob Keller
2020-07-18 11:35 ` Vladimir Oltean
2020-07-20 18:54 ` Jacob Keller
2020-07-20 21:05 ` Vladimir Oltean
2020-07-20 21:45 ` Jacob Keller
2020-07-20 22:13 ` Vladimir Oltean
2020-07-21 0:21 ` Richard Cochran [this message]
2020-07-21 19:51 ` Vladimir Oltean
2020-07-22 3:25 ` Richard Cochran
2020-07-25 21:32 ` Vladimir Oltean
2020-07-21 17:16 ` Jacob Keller
2020-07-21 0:15 ` Richard Cochran
2020-07-17 21:13 ` [PATCH net-next 0/3] Document more PTP timestamping known quirks Sergey Organov
2020-07-17 21:57 ` Vladimir Oltean
2020-07-17 23:13 ` Jacob Keller
2020-07-18 10:54 ` Sergey Organov
2020-07-18 11:30 ` Vladimir Oltean
2020-07-18 13:35 ` Sergey Organov
2020-07-18 11:21 ` Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721002150.GB21585@hoboy \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).