From: Masami Hiramatsu <mhiramat@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 5/6] Documentation: tracing: Add %return suffix description
Date: Tue, 1 Sep 2020 07:27:45 +0900 [thread overview]
Message-ID: <20200901072745.9ca00fc7efeabe9f0cf479e6@kernel.org> (raw)
In-Reply-To: <210c7494-da9e-5314-c648-917493081c32@infradead.org>
On Mon, 31 Aug 2020 11:50:20 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 8/31/20 5:46 AM, Masami Hiramatsu wrote:
> > Add a description of the %return suffix option for kprobe tracer.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > Documentation/trace/kprobetrace.rst | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
> > index c1709165c553..d29d1f9e6721 100644
> > --- a/Documentation/trace/kprobetrace.rst
> > +++ b/Documentation/trace/kprobetrace.rst
>
> Check spacing:
>
> > @@ -37,6 +38,7 @@ Synopsis of kprobe_events
> > based on SYM+offs or MEMADDR.
> > MOD : Module name which has given SYM.
> > SYM[+offs] : Symbol+offset where the probe is inserted.
> > + SYM%return : Return address of the symbol
> > MEMADDR : Address where the probe is inserted.
> > MAXACTIVE : Maximum number of instances of the specified function that
> > can be probed simultaneously, or 0 for the default value
>
> If I remove the '+', the ':' lines up but the SYM does not line up.
> Am I missing something?
>
> @@ -37,6 +38,7 @@ Synopsis of kprobe_events
> based on SYM+offs or MEMADDR.
> MOD : Module name which has given SYM.
> SYM[+offs] : Symbol+offset where the probe is inserted.
> SYM%return : Return address of the symbol
> MEMADDR : Address where the probe is inserted.
> MAXACTIVE : Maximum number of instances of the specified function that
> can be probed simultaneously, or 0 for the default value
>
Oops, that's my typo.
Thank you!
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-08-31 22:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 12:45 [PATCH 0/6] tracing/boot: Add new options for tracing specific period Masami Hiramatsu
2020-08-31 12:45 ` [PATCH 1/6] kprobes: tracing/kprobes: Fix to kill kprobes on initmem after boot Masami Hiramatsu
2020-08-31 16:25 ` kernel test robot
2020-09-01 6:27 ` Masami Hiramatsu
2020-08-31 12:45 ` [PATCH 2/6] tracing/boot: Add per-instance tracing_on option support Masami Hiramatsu
2020-08-31 12:45 ` [PATCH 3/6] Documentation: tracing: Add tracing_on option to boot-time tracer Masami Hiramatsu
2020-08-31 12:46 ` [PATCH 4/6] tracing/kprobes: Support perf-style return probe Masami Hiramatsu
2020-08-31 12:46 ` [PATCH 5/6] Documentation: tracing: Add %return suffix description Masami Hiramatsu
2020-08-31 18:50 ` Randy Dunlap
2020-08-31 22:27 ` Masami Hiramatsu [this message]
2020-09-01 5:46 ` Masami Hiramatsu
2020-08-31 12:46 ` [PATCH 6/6] Documentation: tracing: boot: Add an example of tracing function-calls Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901072745.9ca00fc7efeabe9f0cf479e6@kernel.org \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).