linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Drew DeVault <sir@cmpwn.com>
Cc: linux-doc@vger.kernel.org
Subject: Re: [PATCH 4/4] submitting-patches.rst: presume git will be used
Date: Thu, 3 Sep 2020 09:57:35 -0600	[thread overview]
Message-ID: <20200903095735.0793c054@lwn.net> (raw)
In-Reply-To: <20200902155759.55895-5-sir@cmpwn.com>

On Wed,  2 Sep 2020 11:57:59 -0400
Drew DeVault <sir@cmpwn.com> wrote:

> Git is fairly ubiquitous these days, and the additional information in
> this documentation for preparing patches without it is not especially
> relevant anymore and may serve to confuse new contributors.
> 
> Signed-off-by: Drew DeVault <sir@cmpwn.com>

This is generally good, but I have a comment (of course!)...

[...]

> @@ -380,13 +326,17 @@ server, and provide instead a URL (link) pointing to your patch.  But note
>  that if your patch exceeds 300 kB, it almost certainly needs to be broken up
>  anyway.
>  
> -8) Respond to review comments
> +``git request-pull`` may be used to generate an email which summarizes your changes
> +and provides a URL to fetch your tree from. See :ref:`_request_pull`.

I'm not sure we want to be suggesting pull requests in our basic document
on patch submission.  Few, if any, maintainers will pull from developers
who still need this document.

Actually, I think this whole section ("E-mail size") is wrong, now that I
look at it.  People who post patches behind a URL rarely get a favorable
response.  Maybe we should just delete that section entirely?

Thanks,

jon

      parent reply	other threads:[~2020-09-03 15:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 15:57 [PATCH 0/4] Improvements to submitting-patches.rst Drew DeVault
2020-09-02 15:57 ` [PATCH 1/4] submitting-patches.rst: remove heading numbering Drew DeVault
2020-09-03 15:44   ` Jonathan Corbet
2020-09-03 15:48     ` Drew DeVault
2020-09-03 15:46   ` Jonathan Corbet
2020-09-02 15:57 ` [PATCH 2/4] Documentation/process: expand plain-text advice Drew DeVault
2020-09-02 16:06   ` Randy Dunlap
2020-09-02 16:20     ` Drew DeVault
2020-09-03 15:47   ` Jonathan Corbet
2020-09-02 15:57 ` [PATCH 3/4] Documentation/maintainer: rehome sign-off process Drew DeVault
2020-09-03 15:50   ` Jonathan Corbet
2020-09-02 15:57 ` [PATCH 4/4] submitting-patches.rst: presume git will be used Drew DeVault
2020-09-02 16:11   ` Randy Dunlap
2020-09-02 16:11     ` Drew DeVault
2020-09-03 15:57   ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903095735.0793c054@lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=sir@cmpwn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).