From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 21/23] gpio: mockup: provide a way to delete dummy chips
Date: Fri, 4 Sep 2020 17:45:45 +0200 [thread overview]
Message-ID: <20200904154547.3836-22-brgl@bgdev.pl> (raw)
In-Reply-To: <20200904154547.3836-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Add a new debugfs attribute 'delete_device' to which the chip label can
be written to dynamically remove the associated dummy device.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/gpio/gpio-mockup.c | 70 +++++++++++++++++++++++++++++++++++++-
1 file changed, 69 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 1353239dc315..9d2de78a45c2 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/slab.h>
+#include <linux/string.h>
#include <linux/string_helpers.h>
#include <linux/uaccess.h>
@@ -668,14 +669,81 @@ static int __init gpio_mockup_register_chips_from_params(void)
return 0;
}
-static int __init gpio_mockup_init(void)
+static ssize_t gpio_mockup_debugfs_delete_device_write(struct file *file,
+ const char __user *usr_buf,
+ size_t size, loff_t *ppos)
{
+ struct gpio_mockup_device *mockup_dev;
+ char label[GPIO_MOCKUP_LABEL_SIZE];
+ struct list_head *curr;
+ struct device *dev;
+ const char *prop;
int ret;
+ if (*ppos != 0)
+ return -EINVAL;
+
+ ret = getline_from_user(label, sizeof(label), usr_buf, size);
+ if (ret < 0)
+ return ret;
+
+ mutex_lock(&gpio_mockup_devices_lock);
+
+ list_for_each(curr, &gpio_mockup_devices) {
+ mockup_dev = list_entry(curr, struct gpio_mockup_device, list);
+ dev = &mockup_dev->pdev->dev;
+
+ ret = device_property_read_string(dev, "chip-label", &prop);
+ if (ret) {
+ mutex_unlock(&gpio_mockup_devices_lock);
+ return ret;
+ }
+
+ if (sysfs_streq(label, prop)) {
+ gpio_mockup_unregister_one_device(mockup_dev);
+ mutex_unlock(&gpio_mockup_devices_lock);
+ return size;
+ }
+ }
+
+ mutex_unlock(&gpio_mockup_devices_lock);
+ return -ENODEV;
+}
+
+static const struct file_operations gpio_mockup_debugfs_delete_device_ops = {
+ .owner = THIS_MODULE,
+ .open = gpio_mockup_debugfs_open,
+ .write = gpio_mockup_debugfs_delete_device_write,
+ .llseek = no_llseek,
+ .release = single_release,
+};
+
+static int __init gpio_mockup_debugfs_init(void)
+{
+ struct dentry *entry;
+
gpio_mockup_dbg_dir = debugfs_create_dir("gpio-mockup", NULL);
if (IS_ERR(gpio_mockup_dbg_dir))
return PTR_ERR(gpio_mockup_dbg_dir);
+ entry = debugfs_create_file("delete_device", 0200, gpio_mockup_dbg_dir,
+ NULL, &gpio_mockup_debugfs_delete_device_ops);
+ if (IS_ERR(entry)) {
+ debugfs_remove_recursive(gpio_mockup_dbg_dir);
+ return PTR_ERR(entry);
+ }
+
+ return 0;
+}
+
+static int __init gpio_mockup_init(void)
+{
+ int ret;
+
+ ret = gpio_mockup_debugfs_init();
+ if (ret)
+ return ret;
+
ret = platform_driver_register(&gpio_mockup_driver);
if (ret) {
pr_err("error registering platform driver\n");
--
2.26.1
next prev parent reply other threads:[~2020-09-04 15:48 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:45 [PATCH 00/23] gpio: mockup: support dynamically created and removed chips Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 01/23] lib: cmdline: export next_arg() Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 02/23] lib: string_helpers: provide kfree_strarray() Bartosz Golaszewski
2020-09-04 16:33 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 03/23] lib: uaccess: provide getline_from_user() Bartosz Golaszewski
2020-09-04 16:35 ` Andy Shevchenko
2020-09-07 10:02 ` Bartosz Golaszewski
2020-09-07 10:18 ` Andy Shevchenko
2020-09-07 10:28 ` Bartosz Golaszewski
2020-09-07 11:45 ` Andy Shevchenko
2020-09-07 11:57 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 04/23] gpiolib: generalize devprop_gpiochip_set_names() for device properties Bartosz Golaszewski
2020-09-04 16:38 ` Andy Shevchenko
2020-09-07 10:56 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 05/23] gpiolib: unexport devprop_gpiochip_set_names() Bartosz Golaszewski
2020-09-04 16:40 ` Andy Shevchenko
2020-09-07 10:53 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 06/23] gpiolib: switch to simpler IDA interface Bartosz Golaszewski
2020-09-04 16:41 ` Andy Shevchenko
2020-09-07 10:50 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 07/23] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 08/23] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-04 16:29 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 09/23] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-04 16:30 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 10/23] gpio: mockup: fix resource leak in error path Bartosz Golaszewski
2020-09-04 17:00 ` Andy Shevchenko
2020-09-07 11:04 ` Bartosz Golaszewski
2020-09-07 11:47 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 11/23] gpio: mockup: remove the limit on number of dummy chips Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 12/23] gpio: mockup: define a constant for chip label size Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 13/23] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-04 16:48 ` Andy Shevchenko
2020-09-07 11:01 ` Bartosz Golaszewski
2020-09-07 11:48 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 14/23] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-04 16:46 ` Andy Shevchenko
2020-09-07 10:58 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 15/23] gpio: mockup: use dynamic device IDs Bartosz Golaszewski
2020-09-04 16:49 ` Andy Shevchenko
2020-09-07 11:04 ` Bartosz Golaszewski
2020-09-07 11:50 ` Andy Shevchenko
2020-09-07 11:59 ` Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 16/23] gpio: mockup: refactor the module init function Bartosz Golaszewski
2020-09-04 16:50 ` Andy Shevchenko
2020-09-07 11:05 ` Bartosz Golaszewski
2020-09-07 11:51 ` Andy Shevchenko
2020-09-04 15:45 ` [PATCH 17/23] gpio: mockup: rename and move around debugfs callbacks Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 18/23] gpio: mockup: require debugfs to build Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 19/23] gpio: mockup: add a symlink for the per-chip debugfs directory Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 20/23] gpio: mockup: add a lock for dummy device list Bartosz Golaszewski
2020-09-04 15:45 ` Bartosz Golaszewski [this message]
2020-09-04 16:56 ` [PATCH 21/23] gpio: mockup: provide a way to delete dummy chips Andy Shevchenko
2020-09-04 15:45 ` [PATCH 22/23] gpio: mockup: provide a way to create new " Bartosz Golaszewski
2020-09-04 15:45 ` [PATCH 23/23] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-04 16:58 ` Andy Shevchenko
2020-09-05 3:15 ` Randy Dunlap
2020-09-07 9:59 ` Andy Shevchenko
2020-09-07 10:26 ` Bartosz Golaszewski
2020-09-07 11:53 ` Andy Shevchenko
2020-09-07 12:06 ` Bartosz Golaszewski
2020-09-07 12:22 ` Greg Kroah-Hartman
2020-09-07 13:49 ` Bartosz Golaszewski
2020-09-07 14:08 ` Andy Shevchenko
2020-09-07 15:14 ` Bartosz Golaszewski
2020-09-07 15:23 ` Geert Uytterhoeven
2020-09-07 16:08 ` Bartosz Golaszewski
2020-09-08 17:03 ` Bartosz Golaszewski
2020-09-11 12:56 ` Greg Kroah-Hartman
2020-09-11 13:07 ` Bartosz Golaszewski
2020-09-07 12:38 ` Andy Shevchenko
2020-09-07 12:57 ` Bartosz Golaszewski
2020-09-07 13:52 ` Andy Shevchenko
2020-09-07 10:45 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904154547.3836-22-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).