From: "Paul E. McKenney" <paulmck@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Fox Chen <foxhlchen@gmail.com>,
stern@rowland.harvard.edu, parri.andrea@gmail.com,
peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
corbet@lwn.net, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] docs/memory-barriers.txt: Fix a typo in CPU MEMORY BARRIERS section
Date: Mon, 14 Sep 2020 08:33:37 -0700 [thread overview]
Message-ID: <20200914153337.GZ29330@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200911140218.GB19961@willie-the-truck>
On Fri, Sep 11, 2020 at 03:02:19PM +0100, Will Deacon wrote:
> On Wed, Sep 09, 2020 at 02:53:40PM +0800, Fox Chen wrote:
> > Commit 39323c6 smp_mb__{before,after}_atomic(): update Documentation
> > has a typo in CPU MEORY BARRIERS section:
> > "RMW functions that do not imply are memory barrier are ..." should be
> > "RMW functions that do not imply a memory barrier are ...".
> >
> > This patch fixes this typo.
> >
> > Signed-off-by: Fox Chen <foxhlchen@gmail.com>
> > ---
> > Documentation/memory-barriers.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> > index 96186332e5f4..20b8a7b30320 100644
> > --- a/Documentation/memory-barriers.txt
> > +++ b/Documentation/memory-barriers.txt
> > @@ -1870,7 +1870,7 @@ There are some more advanced barrier functions:
> >
> > These are for use with atomic RMW functions that do not imply memory
> > barriers, but where the code needs a memory barrier. Examples for atomic
> > - RMW functions that do not imply are memory barrier are e.g. add,
> > + RMW functions that do not imply a memory barrier are e.g. add,
> > subtract, (failed) conditional operations, _relaxed functions,
> > but not atomic_read or atomic_set. A common example where a memory
> > barrier may be required is when atomic ops are used for reference
>
> The document remains unreadable, but this is still worth fixing!
>
> Acked-by: Will Deacon <will@kernel.org>
Queued for v5.11, thank you both!
Thanx, Paul
prev parent reply other threads:[~2020-09-14 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 6:53 [PATCH] docs/memory-barriers.txt: Fix a typo in CPU MEMORY BARRIERS section Fox Chen
2020-09-11 14:02 ` Will Deacon
2020-09-14 15:33 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914153337.GZ29330@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=foxhlchen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox