From: Jonathan Corbet <corbet@lwn.net>
To: NeilBrown <neilb@suse.de>
Cc: linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc: seq_file: clarify role of *pos in ->next()
Date: Mon, 28 Sep 2020 15:19:58 -0600 [thread overview]
Message-ID: <20200928151958.43d3822d@lwn.net> (raw)
In-Reply-To: <87eemqiazh.fsf@notabene.neil.brown.name>
On Fri, 25 Sep 2020 17:14:42 +1000
NeilBrown <neilb@suse.de> wrote:
> There are behavioural requirements on the seq_file next() function in
> terms of how it updates *pos at end-of-file, and these are now enforced
> by a warning.
>
> I was recently attempting to justify the reason this was needed, and
> couldn't remember the details, and didn't find them in the
> documentation.
>
> So I re-read the code until I understood it again, and updated the
> documentation to match.
>
> I also enhanced the text about SEQ_START_TOKEN as it seemed potentially
> misleading.
>
> Cc: Vasily Averin <vvs@virtuozzo.com>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> Documentation/filesystems/seq_file.rst | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
Applied, thanks.
jon
prev parent reply other threads:[~2020-09-28 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 7:14 [PATCH] doc: seq_file: clarify role of *pos in ->next() NeilBrown
2020-09-28 21:19 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928151958.43d3822d@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox