linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 01/10] lib: string_helpers: provide kfree_strarray()
Date: Tue, 29 Sep 2020 12:09:55 +0200	[thread overview]
Message-ID: <20200929101004.20288-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20200929101004.20288-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

There's a common pattern of dynamically allocating an array of char
pointers and then also dynamically allocating each string in this
array. Provide a helper for freeing such a string array with one call.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/string_helpers.h |  2 ++
 lib/string_helpers.c           | 24 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
index 86f150c2a6b6..fa06dcdc481e 100644
--- a/include/linux/string_helpers.h
+++ b/include/linux/string_helpers.h
@@ -94,4 +94,6 @@ char *kstrdup_quotable(const char *src, gfp_t gfp);
 char *kstrdup_quotable_cmdline(struct task_struct *task, gfp_t gfp);
 char *kstrdup_quotable_file(struct file *file, gfp_t gfp);
 
+void kfree_strarray(char **array, size_t n);
+
 #endif
diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 963050c0283e..efeee2353613 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -649,3 +649,27 @@ char *kstrdup_quotable_file(struct file *file, gfp_t gfp)
 	return pathname;
 }
 EXPORT_SYMBOL_GPL(kstrdup_quotable_file);
+
+/**
+ * kfree_strarray - free a number of dynamically allocated strings contained
+ *                  in an array and the array itself
+ *
+ * @array: Dynamically allocated array of strings to free. If NULL - the
+ *         function does nothing.
+ * @n: Number of strings (starting from the beginning of the array) to free.
+ *
+ * Passing a non-null @array and @n == 0 as well as NULL @array  are valid
+ * use-cases.
+ */
+void kfree_strarray(char **array, size_t n)
+{
+	unsigned int i;
+
+	if (!array)
+		return;
+
+	for (i = 0; i < n; i++)
+		kfree(array[i]);
+	kfree(array);
+}
+EXPORT_SYMBOL_GPL(kfree_strarray);
-- 
2.26.1


  reply	other threads:[~2020-09-29 10:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 10:09 [PATCH v3 00/10] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-29 10:09 ` Bartosz Golaszewski [this message]
2020-09-29 10:51   ` [PATCH v3 01/10] lib: string_helpers: provide kfree_strarray() Andy Shevchenko
2020-09-29 10:09 ` [PATCH v3 02/10] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 03/10] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 04/10] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-29 10:09 ` [PATCH v3 05/10] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 06/10] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 07/10] gpio: mockup: increase the number of supported device properties Bartosz Golaszewski
2020-09-29 10:53   ` Andy Shevchenko
2020-09-30  8:05     ` Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 08/10] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-29 10:53   ` Andy Shevchenko
2020-09-29 10:10 ` [PATCH v3 09/10] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-29 10:10 ` [PATCH v3 10/10] gpio: mockup: refactor the module init function Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929101004.20288-2-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).