From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1A6C4346E for ; Tue, 29 Sep 2020 10:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6CE3208FE for ; Tue, 29 Sep 2020 10:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725774AbgI2Kxb (ORCPT ); Tue, 29 Sep 2020 06:53:31 -0400 Received: from mga14.intel.com ([192.55.52.115]:56592 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgI2Kxb (ORCPT ); Tue, 29 Sep 2020 06:53:31 -0400 IronPort-SDR: jAKCeDKF9cTH1XH888gZfDIFxsAdTVpEerJjxC/6WIup48L/SVsUCh0JixbfUBZ+yUANFlgYOb qHAJGaDzg0Hw== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="161389029" X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="161389029" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 03:53:28 -0700 IronPort-SDR: d1dT1ERsDeSGD6+2f5WluvaQkB+E/4AMF4TBIPQhgediepRXdfvrvyZ8mtAg/YgI5y7gOcdzi0 SC6yNt07zmxA== X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="312173046" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 03:53:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kNDG4-002lz6-QZ; Tue, 29 Sep 2020 13:53:20 +0300 Date: Tue, 29 Sep 2020 13:53:20 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jonathan Corbet , Kent Gibson , linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 07/10] gpio: mockup: increase the number of supported device properties Message-ID: <20200929105320.GF3956970@smile.fi.intel.com> References: <20200929101004.20288-1-brgl@bgdev.pl> <20200929101004.20288-8-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929101004.20288-8-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Sep 29, 2020 at 12:10:01PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver actually supports 4 properties but we only ever set up up to > three. This will change however in upcoming patches so increase the > number of really (as in: the number the property array can hold) > supported properties to 4. Reviewed-by: Andy Shevchenko Reported-by ? (it does not imply the necessity of Fixes tag) > Signed-off-by: Bartosz Golaszewski > --- > drivers/gpio/gpio-mockup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index de778b52f355..856ba5da1e8c 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -29,8 +29,8 @@ > * of GPIO lines. > */ > #define GPIO_MOCKUP_MAX_RANGES (GPIO_MOCKUP_MAX_GC * 2) > -/* Maximum of three properties + the sentinel. */ > -#define GPIO_MOCKUP_MAX_PROP 4 > +/* Maximum of four properties + the sentinel. */ > +#define GPIO_MOCKUP_MAX_PROP 5 > > /* > * struct gpio_pin_status - structure describing a GPIO status > -- > 2.26.1 > -- With Best Regards, Andy Shevchenko