From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489BCC47423 for ; Tue, 29 Sep 2020 21:53:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB21E21548 for ; Tue, 29 Sep 2020 21:53:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=laptop-org.20150623.gappssmtp.com header.i=@laptop-org.20150623.gappssmtp.com header.b="E33XYTuK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbgI2VxJ (ORCPT ); Tue, 29 Sep 2020 17:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728161AbgI2VxI (ORCPT ); Tue, 29 Sep 2020 17:53:08 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96DEFC0613D1 for ; Tue, 29 Sep 2020 14:53:08 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id f18so6059958pfa.10 for ; Tue, 29 Sep 2020 14:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=laptop-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f/gWOu1TrRoNXxwTjONo7o5+Ij7ibEG5IfBYm/+HET8=; b=E33XYTuKaxFZeZYJMW6eTtEGrlyGXTkwcx/zyYE4FwwLi+COEW+yWd/+0Cf95/WGtY gA86BU5Drjiy9diRFKDvzElxjUhLaGUOgLxvPHqm4KrxiVokwNDSCtjIpcES/TpEIpc6 dVmJeB/tex75y/Bc/sY6UtXa0A77E3dRr5L+1KAoi+AbU1W6Vt9GYfXyFtcOrRf/wp6Q D0a6jDjLfVX1kaG9HLQV63nTT6mPqCav4kqlRwsiC9ZYjBegbY+4NXor8wgJHhd2Y461 EpM2ZClNwNHNBuUJ9Q6GRMia0EL2Pv5QHFBk+FzsVmbnGLFb638dkqk6/2raUfpv9cRX /G4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f/gWOu1TrRoNXxwTjONo7o5+Ij7ibEG5IfBYm/+HET8=; b=kbkOcRudu2PCUG1gkeI6YrCagKkxjojqa3/+vFEkrnSBEMXvIWf3EwQWycuP8GlVaT IfJ9XUUpQYSfHeVDDaS/+fVashF+5kd4ifWCrnY1T9mdMcjXCTSyiTd8XADbfbzxC9HT R+88qUEynqOtXjW261bLblhNLGXDw3ZBbvdGuaA12yAMcM4aVXalsp+64AVBcuO0kLGE IUDInUD+T7Zzvnrsj+jHmH20BAnhuJ9X5XlQmE1T3AkLAwz1VEniB9AOskGtCX7xIBWz 1g60WnxTIlWKpj8Y+in6GND9KWRIS7BpdUNETtw5WzXvZlw5UgGACnZfgK0H8k3oXBmz 0Zpg== X-Gm-Message-State: AOAM532fEz/aH4EglHYJnabhDgO3HMiMUOv2XvI34D9EyWnZps0WvLRf EnLqMgC+EN4eBgULrJjxt/wvbA== X-Google-Smtp-Source: ABdhPJzIeNXHHc94ebLFB9qkrPXXAtz33vlk/UqWEatHhLEUSYCsDM/sIDsnSGbSOH4e+0OMNyZK5g== X-Received: by 2002:a63:2845:: with SMTP id o66mr4631601pgo.77.1601416387878; Tue, 29 Sep 2020 14:53:07 -0700 (PDT) Received: from esk ([1.129.134.212]) by smtp.gmail.com with ESMTPSA id l79sm6516011pfd.210.2020.09.29.14.53.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Sep 2020 14:53:07 -0700 (PDT) Received: from james by esk with local (Exim 4.90_1) (envelope-from ) id 1kNNYV-0004eb-0z; Wed, 30 Sep 2020 07:53:03 +1000 Date: Wed, 30 Sep 2020 07:53:03 +1000 From: James Cameron To: Thomas Gleixner Cc: LKML , Andrew Lunn , Emmanuel Grumbach , linux-doc@vger.kernel.org, Peter Zijlstra , Chris Snook , Sebastian Andrzej Siewior , Christian Benvenuti , Arend van Spriel , Govindarajulu Varadarajan <_govind@gmx.com>, Vishal Kulkarni , Luca Coelho , Edward Cree , libertas-dev@lists.infradead.org, brcm80211-dev-list@cypress.com, brcm80211-dev-list.pdl@broadcom.com, Ping-Ke Shih , Johannes Berg , Jonathan Corbet , Mauro Carvalho Chehab , Intel Linux Wireless , Russell King , Matthew Wilcox , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , Jakub Kicinski , Martin Habets , Ulrich Kunitz , Jay Cliburn , Paul McKenney , Stanislaw Gruszka , Jouni Malinen , Hante Meuleman , Pascal Terjan , Amitkumar Karwar , Wright Feng , Daniel Drake , Pensando Drivers , Kalle Valo , Franky Lin , Solarflare linux maintainers , Thomas Bogendoerfer , Chi-Hsien Lin , Xinming Hu , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, Greg Kroah-Hartman , Ganapathi Bhat , Stanislav Yakovlev , Jon Mason , Shannon Nelson , Dave Miller , Luc Van Oostenryck , Heiner Kallweit Subject: Re: [patch V2 33/36] net: libertas: Use netif_rx_any_context() Message-ID: <20200929215302.GB16571@laptop.org> References: <20200929202509.673358734@linutronix.de> <20200929203502.769744809@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929203502.769744809@linutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Sep 29, 2020 at 10:25:42PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > The usage of in_interrupt() in non-core code is phased out. Ideally the > information of the calling context should be passed by the callers or the > functions be split as appropriate. > > libertas uses in_interupt() to select the netif_rx*() variant which matches > the calling context. The attempt to consolidate the code by passing an > arguemnt or by distangling it failed due lack of knowledge about this > driver and because the call chains are hard to follow. > > As a stop gap use netif_rx_any_context() which invokes the correct code > path depending on context and confines the in_interrupt() usage to core > code. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Acked-by: Kalle Valo Reviewed-by: James Cameron -- James Cameron http://quozl.netrek.org/