From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDA8C4363C for ; Wed, 7 Oct 2020 09:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A04A92083B for ; Wed, 7 Oct 2020 09:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602061536; bh=42RhLHhep8milANosAI5Nau1e18GjKFGz66AsIO6JMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BSjIejCEqYkB1etAXt8hDrP+74e3ror07SxRENbIGJqJ+kWDsNaOiLZTw4AMzl7h+ M1B0kBV+WjddqcgQPdJiOJfCY0Yw19KmCE9lzRgvYlV7XHrXbfyLqBnFjAmFWnudDA +II+uvh73y3O9tVxoutqA5oDkLy4pSMgiloSaFPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbgJGJFg (ORCPT ); Wed, 7 Oct 2020 05:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:46846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbgJGJFg (ORCPT ); Wed, 7 Oct 2020 05:05:36 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B688020789; Wed, 7 Oct 2020 09:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602061535; bh=42RhLHhep8milANosAI5Nau1e18GjKFGz66AsIO6JMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wZFTtaczrJZawEoTP9QnsqHrkJkv08bjAP9AuD6t1/X60ifioT4VhKev2sTPuUCbW t1+XgmO8aKMj0qAMoTAoRutFtl9yd5963n5vGr/oTJE6d4egUx5QedpVYQHfYkv7B4 Vprk1nNZhDZivHvtn4u3IE4+rjlMEtcJC6ILYKK0= Date: Wed, 7 Oct 2020 11:06:19 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: Ivan Zaentsev , Evgeniy Polyakov , Jonathan Corbet , Akira Shimahara , Dan Carpenter , Colin Ian King , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Evgeny Boger Subject: Re: [PATCH 2/2] w1: w1_therm: Add support for GXCAS GX20MH01 device. Message-ID: <20201007090619.GA613204@kroah.com> References: <20200904160004.87710-1-ivan.zaentsev@wirenboard.ru> <20200904160004.87710-2-ivan.zaentsev@wirenboard.ru> <20201006151915.77d044a4@coco.lan> <1561045277.20201007103227@wirenboard.ru> <20201007105702.67988846@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007105702.67988846@coco.lan> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Oct 07, 2020 at 10:57:02AM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 7 Oct 2020 10:32:27 +0300 > Ivan Zaentsev escreveu: > > > Tuesday, October 6, 2020, 4:19:15 PM, Mauro Carvalho Chehab wrote: > > > > >> diff --git a/Documentation/w1/slaves/w1_therm.rst b/Documentation/w1/slaves/w1_therm.rst > > >> index f1148181f53e..00376501a5ef 100644 > > >> --- a/Documentation/w1/slaves/w1_therm.rst > > >> +++ b/Documentation/w1/slaves/w1_therm.rst > > > > >> > > >> @@ -130,4 +131,12 @@ conversion and temperature reads 85.00 (powerup value) or 127.94 (insufficient > > >> power), the driver returns a conversion error. Bit mask ``2`` enables poll for > > >> conversion completion (normal power only) by generating read cycles on the bus > > >> after conversion starts. In parasite power mode this feature is not available. > > >> -Feature bit masks may be combined (OR). > > >> +Feature bit masks may be combined (OR). See accompanying sysfs documentation: > > >> +:ref:`Documentation/w1/slaves/w1_therm.rst ` > > >> + > > > > > As warned by Sphinx, this cross-reference is broken: > > > > > .../Documentation/w1/slaves/w1_therm.rst:125: WARNING: > > > undefined label: w1_therm (if the link has no caption the label must precede a section header) > > > > Would this be ok? > > Yeah, sure! > > > > > "More details in Documentation/ABI/testing/sysfs-driver-w1_therm" > > > > > Not sure what you wanted to point here. > > > > A link to a driver's sysfs interface, but sysfs docs are text > > files and seem to not be included in Sphynx Docs. > > I sent upstream sometime ago a patch series adding ABI to Sphinx, but I > was not merged, not sure why: > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=abi_patches_v5.6 I think the raft of different patches floating around at the time made me totally confused as to what was, and was not, the latest versions. I'll be glad to look at them again, if you want to rebase after 5.10-rc1 is out and resend them, as I think this should be showing up in the documentation. thanks, greg k-h