From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6A9C388F9 for ; Fri, 23 Oct 2020 19:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ED752192A for ; Fri, 23 Oct 2020 19:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbgJWTsB (ORCPT ); Fri, 23 Oct 2020 15:48:01 -0400 Received: from ms.lwn.net ([45.79.88.28]:51894 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754840AbgJWTsB (ORCPT ); Fri, 23 Oct 2020 15:48:01 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 996EA7DE; Fri, 23 Oct 2020 19:47:59 +0000 (UTC) Date: Fri, 23 Oct 2020 13:47:57 -0600 From: Jonathan Corbet To: Peter Zijlstra Cc: Kees Cook , Mauro Carvalho Chehab , Linux Doc Mailing List , Ard Biesheuvel , Ingo Molnar , Jann Horn , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 49/56] refcount.h: fix a kernel-doc markup Message-ID: <20201023134757.628f91b7@lwn.net> In-Reply-To: <20201023193907.GI2974@worktop.programming.kicks-ass.net> References: <202010231039.DE05B63@keescook> <20201023193907.GI2974@worktop.programming.kicks-ass.net> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, 23 Oct 2020 21:39:07 +0200 Peter Zijlstra wrote: > > > /** > > > - * struct refcount_t - variant of atomic_t specialized for reference counts > > > + * struct refcount_struct - variant of atomic_t specialized for reference counts > > > > Hm, this is a weird one. Yes, it's actually "struct refcount_struct", > > but the usage should be refcount_t (through the typedef). I'm not sure > > what the right way to document this is. > > Yeah, this is wrong. If this is due to a kernel doc warning, the kernel > doc machinery is wrong *again*. ...except that, since refcount_t is a typedef, "struct refcount_t" doesn't actually exist. Whether it works properly after doing s/struct// remains to be seen... jon