From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6168C55178 for ; Thu, 29 Oct 2020 10:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 744AC20790 for ; Thu, 29 Oct 2020 10:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603965845; bh=lsFw3OOqgVhP+yvjAUcffFTse7k37g09prNTuvTfXMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=yCGZzmUfkDiVRx+MrEWNiT7UnnJBZfcsTI70tlIewaERSon7BkFbwfFm21FOLFRpv 6qUU+biiskZIm4Fo7tVfPOhPMuGcmiBxP579xJ62zFqJxDBHNuI9GadculDH505IO0 deQ2tRqxeF/Z2XnhBT2jrfdaUuMigzstKKGdwyFc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725775AbgJ2KEC (ORCPT ); Thu, 29 Oct 2020 06:04:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:45244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgJ2KEC (ORCPT ); Thu, 29 Oct 2020 06:04:02 -0400 Received: from coco.lan (ip5f5ad5de.dynamic.kabel-deutschland.de [95.90.213.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C955206E3; Thu, 29 Oct 2020 10:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603965841; bh=lsFw3OOqgVhP+yvjAUcffFTse7k37g09prNTuvTfXMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EIRZlzcK0Ha52CG9CUUqZCCnW21XlR1KefcFtyDGms+ygaOAPTnebxZK5GYE867ps nEHNsHoGiuLnQIuQRUWMI3qHLBBpiNfWpMJq/k74zHThwDntICO9NbgZasJ4SiO3jV oaFfZfWRjKuyDh4oICuaviZsGxygwwHozLARW8D4= Date: Thu, 29 Oct 2020 11:03:53 +0100 From: Mauro Carvalho Chehab To: Divya Bharathi Cc: dvhart@infradead.org, LKML , platform-driver-x86@vger.kernel.org, Divya Bharathi , Hans de Goede , Andy Shevchenko , mark gross , Mario Limonciello , Prasanth KSR , Greg Kroah-Hartman , Linux Doc Mailing List Subject: Re: [PATCH v7] Introduce support for Systems Management Driver over WMI for Dell Systems Message-ID: <20201029110353.6c8dfb61@coco.lan> In-Reply-To: <20201029090114.64daf4e3@coco.lan> References: <20201027134944.316730-1-divya.bharathi@dell.com> <20201029090114.64daf4e3@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Em Thu, 29 Oct 2020 09:01:14 +0100 Mauro Carvalho Chehab escreveu: > Em Tue, 27 Oct 2020 19:19:44 +0530 > Divya Bharathi escreveu: > > > The Dell WMI Systems Management Driver provides a sysfs > > interface for systems management to enable BIOS configuration > > capability on certain Dell Systems. > > > > This driver allows user to configure Dell systems with a > > uniform common interface. To facilitate this, the patch > > introduces a generic way for driver to be able to create > > configurable BIOS Attributes available in Setup (F2) screen. > > > > Cc: Hans de Goede > > Cc: Andy Shevchenko > > Cc: mark gross > > > > Co-developed-by: Mario Limonciello > > Signed-off-by: Mario Limonciello > > Co-developed-by: Prasanth KSR > > Signed-off-by: Prasanth KSR > > Signed-off-by: Divya Bharathi > > --- > > > > +What: /sys/class/firmware-attributes/*/authentication/ > > +Date: February 2021 > > +KernelVersion: 5.11 > > +Contact: Divya Bharathi , > > + Mario Limonciello , > > + Prasanth KSR > > + > > + Devices support various authentication mechanisms which can be exposed > > + as a separate configuration object. > > + > > + For example a "BIOS Admin" password and "System" Password can be set, > > + reset or cleared using these attributes. > > + - An "Admin" password is used for preventing modification to the BIOS > > + settings. > > + - A "System" password is required to boot a machine. > > + > > This is adding a new warning: > > $ ./scripts/get_abi.pl validate > Warning: file Documentation/ABI/testing/sysfs-class-firmware-attributes#172: > What '/sys/class/firmware-attributes/*/authentication/' doesn't have a description > > Because you forgot to add a Description: tag. > > Feel free to either add the enclosed tag to the tree which added this into > linux-next, or to fold id with the original patch. > > Thanks, > Mauro > > ABI: docs: sysfs-class-firmware-attributes: add a missing tag > > The Description: tag is missing, causing this warning with > scripts/get_abi.pl: > > Warning: file Documentation/ABI/testing/sysfs-class-firmware-attributes#172: > What '/sys/class/firmware-attributes/*/authentication/' doesn't have a description > > Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes > index 04a15c72e883..ea1837f1f3c2 100644 > --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes > +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes > @@ -113,7 +113,7 @@ KernelVersion: 5.11 > Contact: Divya Bharathi , > Mario Limonciello , > Prasanth KSR > - > +Description: > Devices support various authentication mechanisms which can be exposed > as a separate configuration object. > > There are a few other warnings produced by it, when generating the ABI output, so, I sent a new patch covering all warnings. If you want to test the ABI file generation, the patchset is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=abi_patches_v7 You can easily build just the sysfs firmware attribute class ABI with something like this: $ mkdir -p fodir && cp Documentation/ABI/testing/sysfs-class-firmware-attributes fodir/ && ./scripts/get_abi.pl rest -dir fodir/ --rst-source >Documentation/foo/abi.rst && make SPHINXDIRS=foo htmldocs You can also see it at: http://www.infradead.org/~mchehab/kernel_docs/foo/abi.html Thanks, Mauro