linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1] scripts: kernel-doc: Restore anonymous enum parsing
Date: Mon, 2 Nov 2020 19:10:41 +0100	[thread overview]
Message-ID: <20201102191041.66179ad6@coco.lan> (raw)
In-Reply-To: <20201102174846.GT4077@smile.fi.intel.com>

Em Mon, 2 Nov 2020 19:48:46 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu:

> On Mon, Nov 02, 2020 at 06:27:43PM +0100, Mauro Carvalho Chehab wrote:
> > Em Mon,  2 Nov 2020 19:06:37 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu:
> >   
> > > The commit d38c8cfb0571 ("scripts: kernel-doc: add support for typedef enum")
> > > broke anonymous enum parsing. Restore it by relying on members rather than
> > > its name.
> > > 
> > > Fixes: d38c8cfb0571 ("scripts: kernel-doc: add support for typedef enum")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > 
> > Patch looks ok to me. Do you have an example about using it for
> > anonymous enum?  
> 
> drivers/pinctrl/intel/pinctrl-intel.c
> 

Thanks! 

Both include/linux/phy.h and drivers/pinctrl/intel/pinctrl-intel.c
are parsing fine after your patch.

So,

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Thanks,
Mauro

  reply	other threads:[~2020-11-02 18:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 17:06 [PATCH v1] scripts: kernel-doc: Restore anonymous enum parsing Andy Shevchenko
2020-11-02 17:27 ` Mauro Carvalho Chehab
2020-11-02 17:48   ` Andy Shevchenko
2020-11-02 18:10     ` Mauro Carvalho Chehab [this message]
2020-11-11 17:13       ` Andy Shevchenko
2020-11-13 22:10 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102191041.66179ad6@coco.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).