From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [RFC] Add kernel-doc test script
Date: Wed, 18 Nov 2020 07:05:15 -0500 [thread overview]
Message-ID: <20201118120515.GA1509407@habkost.net> (raw)
In-Reply-To: <19ebee73-0e7a-7dc1-5948-072ae153e383@redhat.com>
On Wed, Nov 18, 2020 at 09:21:11AM +0100, Paolo Bonzini wrote:
> On 17/11/20 23:36, Eduardo Habkost wrote:
> > +# the -man output includes the build date
> > +export KBUILD_BUILD_TIMESTAMP=1991-08-25
>
> Nice :)
>
> > +ok=yes
> > +
> > +# don't even try to test other formats if -none fails:
> > +test none -none || exit 1
> > +
> > +test rst2 -rst -sphinx-version 3.0.0 || ok=no
>
> Do you want 3.0.0 here too?
Oops! No! I'll fix it.
>
> > +test rst3 -rst -sphinx-version 3.0.0 || ok=no
> > +test man -man || ok=no
>
> Also since you are at it you might as well rename the function to something
> other than "test", it's a bit confusing due to the "test" shell builtin.
Good point. I'll do.
--
Eduardo
next prev parent reply other threads:[~2020-11-18 12:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:47 [PATCH 0/2] kernel-doc: Handle function typedefs Paolo Bonzini
2020-10-30 14:47 ` [PATCH 1/2] kernel-doc: Handle function typedefs that return pointers Paolo Bonzini
2020-10-30 14:47 ` [PATCH 2/2] kernel-doc: Handle function typedefs without asterisks Paolo Bonzini
2020-11-13 22:21 ` Jonathan Corbet
2020-11-13 22:35 ` Paolo Bonzini
2020-11-13 22:39 ` Matthew Wilcox
2020-11-17 21:24 ` Eduardo Habkost
2020-11-17 21:30 ` Matthew Wilcox
2020-11-17 22:36 ` [RFC] Add kernel-doc test script Eduardo Habkost
2020-11-18 0:23 ` Randy Dunlap
2020-11-18 13:03 ` Eduardo Habkost
2020-11-18 16:32 ` Randy Dunlap
2020-11-18 16:57 ` Eduardo Habkost
2020-11-18 16:58 ` Randy Dunlap
2020-11-18 8:21 ` Paolo Bonzini
2020-11-18 12:05 ` Eduardo Habkost [this message]
2020-11-18 16:27 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118120515.GA1509407@habkost.net \
--to=ehabkost@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).