From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D34C64E7B for ; Tue, 1 Dec 2020 13:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB75B2084C for ; Tue, 1 Dec 2020 13:20:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g8r5HIuJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390936AbgLANUE (ORCPT ); Tue, 1 Dec 2020 08:20:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390680AbgLANUE (ORCPT ); Tue, 1 Dec 2020 08:20:04 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDEBDC0613D4 for ; Tue, 1 Dec 2020 05:19:17 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id e7so2586941wrv.6 for ; Tue, 01 Dec 2020 05:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pffIlxOmfR0gBVuszJT4P2RM92yWm19L13Fi6KZxY80=; b=g8r5HIuJm61ScStvkO7mJrI+1nn38z/980CV6TzqHAnq/C/tMpn8R0PxPMpdICIKFz KItikUjWHc9uvevp/742fpTQlJp9GaHVv+u8IxeGH1Eb8zaqaeqs18N/qHN3tAIeTEJc 5bJf9zmO5oXCMIOHPvTM2mV3Zv1N6PSLSx4WNifkn3wEzI5gDFJl0lMu8IyD+oq2rWnW b4H4Dxui2ENwK3LINaVISyu0Uu498hRHfGi7tEXFmE5oEZgj8RCFV/RP+vsy8sirzVOY Eq3m8ra9jGoB+/q/94NpjZJ89tvQ2zIj+da16hIfj48eqsD914RqpXmPGpGwlFLWG2CR ILYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pffIlxOmfR0gBVuszJT4P2RM92yWm19L13Fi6KZxY80=; b=FoexAg/qwisKvDMJ3w7ZKhLZI2cgHizj75ghsIDAcb3eGv33y0aWNual1K+DThiq7y VoWmIMiFpqY8MDriCZ8MKq+b9alT13HNUNVGRDtRzrCsV5z/b0PUSgsHYL4VgiYEsnxK rg6ldXrXHmpC8fc/oaRyB8sO79SDjVI/95CQX5vfl0QyTugEFE5/KPjOOSSR0DOnAuQ2 X8nJiDCWJh95I6Jxbm5rksZaZ/KMVsBHYifH/a4pneEtOIX6nMw9TfE1FKl3MGuCqmIj QnydW1xOEqTqOzwQS9DuDP6iO+GYkRWOa2sIGZI8UCWkupCGIx0uev9SNhtkgwUIkgEb yrMg== X-Gm-Message-State: AOAM530vPdpT1OR3o9VjXSyrsOX5JZrAosjZIqgISzjPuaL8lOz633S4 kPEAs5aRh/JJSKYmAFMQIyE/Zg== X-Google-Smtp-Source: ABdhPJxNpkgurha25ZUu8Qo29Cw4yJ3wJ4kR79/690cFW6P+G6s4//zbglAbpD8RaDoVhiqxuedQsg== X-Received: by 2002:adf:a549:: with SMTP id j9mr3894987wrb.199.1606828756387; Tue, 01 Dec 2020 05:19:16 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:7c5f:5ab5:ac1f:89ce]) by smtp.gmail.com with ESMTPSA id d17sm3237705wro.62.2020.12.01.05.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 05:19:15 -0800 (PST) Date: Tue, 1 Dec 2020 13:19:13 +0000 From: David Brazdil To: Sudeep Holla Cc: kvmarm@lists.cs.columbia.edu, Jonathan Corbet , Catalin Marinas , Will Deacon , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Dennis Zhou , Tejun Heo , Christoph Lameter , Mark Rutland , Lorenzo Pieralisi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v3 06/23] kvm: arm64: Add kvm-arm.protected early kernel parameter Message-ID: <20201201131913.u7m2eifvtus74dra@google.com> References: <20201126155421.14901-1-dbrazdil@google.com> <20201126155421.14901-7-dbrazdil@google.com> <20201127163254.zxdrszlveaxhluwn@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127163254.zxdrszlveaxhluwn@bogus> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hey Sudeep, > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index 526d65d8573a..06c89975c29c 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -2259,6 +2259,11 @@ > > for all guests. > > Default is 1 (enabled) if in 64-bit or 32-bit PAE mode. > > > > + kvm-arm.protected= > > + [KVM,ARM] Allow spawning protected guests whose state > > + is kept private from the host. Only valid for non-VHE. > > + Default is 0 (disabled). > > + > > Sorry for being pedantic. Can we reword this to say valid for > !CONFIG_ARM64_VHE ? I read this as valid only for non-VHE hardware, it may > be just me, but if you agree please update so that it doesn't give remote > idea that it is not valid on VHE enabled hardware. > > I was trying to run this on the hardware and was trying to understand the > details on how to do that. I see what you're saying, but !CONFIG_ARM64_VHE isn't accurate either. The option makes sense if: 1) all cores booted in EL2 == is_hyp_mode_available() 2) ID_AA64MMFR1_EL1.VH=0 or !CONFIG_ARM64_VHE == !is_kernel_in_hyp_mode() The former feels implied for KVM, the latter could be 'Valid if the kernel is running in EL1'? WDYT? -David