From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7940EC64E7A for ; Tue, 1 Dec 2020 14:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28F9D206A5 for ; Tue, 1 Dec 2020 14:03:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kePb5KVk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391295AbgLAODr (ORCPT ); Tue, 1 Dec 2020 09:03:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:47690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388491AbgLAODr (ORCPT ); Tue, 1 Dec 2020 09:03:47 -0500 Received: from coco.lan (ip5f5ad5d9.dynamic.kabel-deutschland.de [95.90.213.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34329206A5; Tue, 1 Dec 2020 14:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606831386; bh=fN4NSS/2Z3e5ZDp6dT8LOOMaJ+kpvmyC/239xA9Oq1s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kePb5KVkqAS71FlmuATQK/WwMBod77n2IDiESe9VYDlwQ+Kk93lNPKZQz2HE8e8c6 FR0RJ4TJ0O2+VouNrgju7q5qrgPW4wnqZRDRKoO82YMXWwVi0kBAsfooq4x1lSTJPV dSik+VGazyEbU0EjntWoaFbiK45G1/El4qfxOn9I= Date: Tue, 1 Dec 2020 15:03:01 +0100 From: Mauro Carvalho Chehab To: Peter Zijlstra Cc: Linux Doc Mailing List , Jonathan Corbet , "Joel Fernandes (Google)" , Davidlohr Bueso , Greg Kroah-Hartman , Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 07/16] completion: drop init_completion define Message-ID: <20201201150249.56132775@coco.lan> In-Reply-To: <20201201125445.GW2414@hirez.programming.kicks-ass.net> References: <20201201125445.GW2414@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Em Tue, 1 Dec 2020 13:54:45 +0100 Peter Zijlstra escreveu: > On Tue, Dec 01, 2020 at 01:09:00PM +0100, Mauro Carvalho Chehab wrote: > > Changeset cd8084f91c02 ("locking/lockdep: Apply crossrelease to completions") > > added a CONFIG_LOCKDEP_COMPLETE (that was later renamed to > > CONFIG_LOCKDEP_COMPLETIONS). > > > > Such changeset renamed the init_completion, and add a macro > > that would either run a modified version or the original code. > > > > However, such code reported too many false positives. So, it > > ended being dropped later on by > > changeset e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks"). > > > > Yet, the define remained there as just: > > > > #define init_completion(x) __init_completion(x) > > > > Get rid of the define, and return __init_completion() function > > to its original name. > > > > Fixes: e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks") > > Signed-off-by: Mauro Carvalho Chehab > > --- > > Your patch is weird, did you add -C 1000 or something? Per a past review request, I used -U32 on this particular series, in order to be able to display the function name and the kernel-doc markup at the same time. I'm enclosing the patch with -U3. Thanks, Mauro [PATCH] completion: drop init_completion define Changeset cd8084f91c02 ("locking/lockdep: Apply crossrelease to completions") added a CONFIG_LOCKDEP_COMPLETE (that was later renamed to CONFIG_LOCKDEP_COMPLETIONS). Such changeset renamed the init_completion, and add a macro that would either run a modified version or the original code. However, such code reported too many false positives. So, it ended being dropped later on by changeset e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks"). Yet, the define remained there as just: #define init_completion(x) __init_completion(x) Get rid of the define, and return __init_completion() function to its original name. Fixes: e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks") diff --git a/include/linux/completion.h b/include/linux/completion.h index bf8e77001f18..51d9ab079629 100644 --- a/include/linux/completion.h +++ b/include/linux/completion.h @@ -28,8 +28,7 @@ struct completion { struct swait_queue_head wait; }; -#define init_completion_map(x, m) __init_completion(x) -#define init_completion(x) __init_completion(x) +#define init_completion_map(x, m) init_completion(x) static inline void complete_acquire(struct completion *x) {} static inline void complete_release(struct completion *x) {} @@ -82,7 +81,7 @@ static inline void complete_release(struct completion *x) {} * This inline function will initialize a dynamically created completion * structure. */ -static inline void __init_completion(struct completion *x) +static inline void init_completion(struct completion *x) { x->done = 0; init_swait_queue_head(&x->wait);