From: Prashant Malani <pmalani@chromium.org>
To: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
heikki.krogerus@linux.intel.com
Cc: bleung@chromium.org, Prashant Malani <pmalani@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org (open list:DOCUMENTATION),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] usb: typec: Add bus type for plug alt modes
Date: Wed, 2 Dec 2020 19:08:47 -0800 [thread overview]
Message-ID: <20201203030846.51669-1-pmalani@chromium.org> (raw)
Add the Type C bus for plug alternate modes which are being
registered via the Type C connector class. This ensures that udev events
get generated when plug alternate modes are registered (and not just for
partner/port alternate modes), even though the Type C bus doesn't link
plug alternate mode devices to alternate mode drivers.
Update the Type C bus documentation to mention that there
are alternate mode devices for plugs as well.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
Documentation/driver-api/usb/typec_bus.rst | 6 +++---
drivers/usb/typec/class.c | 8 ++++++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/Documentation/driver-api/usb/typec_bus.rst b/Documentation/driver-api/usb/typec_bus.rst
index 21c890ae17e5..7874d2f37d9f 100644
--- a/Documentation/driver-api/usb/typec_bus.rst
+++ b/Documentation/driver-api/usb/typec_bus.rst
@@ -15,9 +15,9 @@ modes by using the SVID and the mode number.
:ref:`USB Type-C Connector Class <typec>` provides a device for every alternate
mode a port supports, and separate device for every alternate mode the partner
-supports. The drivers for the alternate modes are bound to the partner alternate
-mode devices, and the port alternate mode devices must be handled by the port
-drivers.
+or cable plug supports. The drivers for the alternate modes are bound to the
+partner alternate mode devices, and the port alternate mode devices must be
+handled by the port drivers.
When a new partner alternate mode device is registered, it is linked to the
alternate mode device of the port that the partner is attached to, that has
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 35eec707cb51..74061a699f16 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -478,8 +478,12 @@ typec_register_altmode(struct device *parent,
if (!is_port)
typec_altmode_set_partner(alt);
- /* The partners are bind to drivers */
- if (is_typec_partner(parent))
+ /*
+ * The partners are bind to drivers.
+ * Also set the bus field for plug alt modes so that the udev event occurs on device
+ * registration.
+ */
+ if (is_typec_partner(parent) || is_typec_plug(parent))
alt->adev.dev.bus = &typec_bus;
ret = device_register(&alt->adev.dev);
--
2.29.2.454.gaff20da3a2-goog
next reply other threads:[~2020-12-03 3:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:08 Prashant Malani [this message]
2020-12-08 9:37 ` [PATCH] usb: typec: Add bus type for plug alt modes Heikki Krogerus
2020-12-08 23:45 ` Prashant Malani
2020-12-09 16:13 ` Heikki Krogerus
2020-12-09 16:22 ` Prashant Malani
2020-12-09 17:15 ` Heikki Krogerus
2020-12-09 22:59 ` Prashant Malani
2020-12-09 23:47 ` Prashant Malani
2020-12-10 11:49 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203030846.51669-1-pmalani@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).