From: Christoph Hellwig <hch@lst.de>
To: Joe Perches <joe@perches.com>
Cc: Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>,
apw@canonical.com, Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-doc <linux-doc@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH] checkpatch: make the line length warnings match the coding style document
Date: Wed, 23 Dec 2020 09:29:50 +0100 [thread overview]
Message-ID: <20201223082950.GA7129@lst.de> (raw)
In-Reply-To: <983e6452a7f2af14ca7edfa56cd2e2997172a771.camel@perches.com>
On Tue, Dec 22, 2020 at 08:22:06AM -0800, Joe Perches wrote:
> Having checkpatch complain about > 80 column lines didn't stop
> patches before, likely it wouldn't stop patches now.
>
> Emitting yet more messages for trivial lines > 80 columns is also
> against the intent of the commit that changed the line length maximum.
It certainly helped. Since that checkpatch change I waste a lot more
of my time on finding all this crap, and people are confused because
they only rely on checkpatch. Other maintainers are similarly annoyed
or just silently fix things up.
Right now this is making things much worse.
prev parent reply other threads:[~2020-12-23 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201210082251.2717564-1-hch@lst.de>
2020-12-10 20:05 ` [PATCH] checkpatch: make the line length warnings match the coding style document Joe Perches
2020-12-10 20:09 ` Matthew Wilcox
2020-12-10 21:27 ` Joe Perches
2020-12-22 4:08 ` Joe Perches
2020-12-22 13:12 ` Christoph Hellwig
2020-12-22 16:22 ` Joe Perches
2020-12-23 8:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223082950.GA7129@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).