From: Paul Fertser <fercerpav@gmail.com>
To: Ernesto Corona <ernesto.corona@intel.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Jeffery <andrew@aj.id.au>,
Steven Filary <steven.a.filary@intel.com>,
Eric Biggers <ebiggers@google.com>,
Amithash Prasad <amithash@fb.com>, Jiri Pirko <jiri@mellanox.com>,
Rgrs <rgrs@protonmail.com>, Joel Stanley <joel@jms.id.au>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Patrick Williams <patrickw3@fb.com>,
Oleksandr Shamray <oleksandrs@mellanox.com>,
Vadim Pasternak <vadimp@mellanox.com>
Subject: Re: [PATCH v29 2/6] dt-binding: jtag: Aspeed 2400 and 2500 series
Date: Tue, 19 Jan 2021 15:04:26 +0300 [thread overview]
Message-ID: <20210119120426.GE2971@home.paul.comp> (raw)
In-Reply-To: <20200413222920.4722-3-ernesto.corona@intel.com>
On Mon, Apr 13, 2020 at 03:29:16PM -0700, Ernesto Corona wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml
> +examples:
> + - |
> + #include <dt-bindings/clock/aspeed-clock.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + jtag: jtag@1e6e4000 {
> + compatible = "aspeed,ast2500-jtag";
> + reg = <0x1e6e4000 0x1c>;
> + clocks = <&syscon ASPEED_CLK_APB>;
> + resets = <&syscon ASPEED_RESET_JTAG_MASTER>;
> + interrupts = <43>;
> + };
It's nice to have an example but shouldn't it also be included in
aspeed-g5.dtsi as part of the patch series if it's known that the
driver works on those SoCs and the peripheral is always present?
--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@gmail.com
next prev parent reply other threads:[~2021-01-19 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 22:29 [PATCH v29 0/6] JTAG driver introduction Ernesto Corona
2020-04-13 22:29 ` [PATCH v29 1/6] drivers: jtag: Add JTAG core driver Ernesto Corona
2021-01-15 11:18 ` Paul Fertser
2020-04-13 22:29 ` [PATCH v29 2/6] dt-binding: jtag: Aspeed 2400 and 2500 series Ernesto Corona
2021-01-19 12:04 ` Paul Fertser [this message]
2020-04-13 22:29 ` [PATCH v29 3/6] Add Aspeed SoC 24xx and 25xx families JTAG master driver Ernesto Corona
2020-09-28 2:17 ` Moritz Fischer
2021-01-15 11:53 ` Paul Fertser
2020-04-13 22:29 ` [PATCH v29 4/6] Documentation: jtag: Add ABI documentation Ernesto Corona
2021-01-19 12:01 ` Paul Fertser
2020-04-13 22:29 ` [PATCH v29 5/6] Documentation jtag: Add JTAG core driver ioctl number Ernesto Corona
2020-04-13 22:29 ` [PATCH v29 6/6] drivers: jtag: Add JTAG core driver Maintainers Ernesto Corona
2020-04-14 9:15 ` Andy Shevchenko
2021-01-15 10:46 ` [PATCH v29 0/6] JTAG driver introduction Paul Fertser
2021-04-06 13:22 ` Andy Shevchenko
2021-04-06 13:34 ` Paul Fertser
2021-04-06 17:00 ` Corona, Ernesto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119120426.GE2971@home.paul.comp \
--to=fercerpav@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amithash@fb.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=ebiggers@google.com \
--cc=ernesto.corona@intel.com \
--cc=jiri@mellanox.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=oleksandrs@mellanox.com \
--cc=patrickw3@fb.com \
--cc=rgrs@protonmail.com \
--cc=steven.a.filary@intel.com \
--cc=tytso@mit.edu \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).