[PATCH] docs: Remove the Microsoft rhetoric

[PATCH] docs: Remove the Microsoft rhetoric

[Yorick de Wid]

From: Yorick de Wid <yorickdewid@users.noreply.github.com>

There is no need to need to name Microsoft. The point is clear without that context.

Signed-off-by: Yorick de Wid <ydewid@gmail.com>
---
 Documentation/process/coding-style.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 98227226c4e..5608ed2931f 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -306,8 +306,7 @@ that counts the number of active users, you should call that
 
 Encoding the type of a function into the name (so-called Hungarian
 notation) is asinine - the compiler knows the types anyway and can check
-those, and it only confuses the programmer. No wonder Microsoft makes buggy
-programs.
+those, and it only confuses the programmer.
 
 LOCAL variable names should be short, and to the point.  If you have
 some random integer loop counter, it should probably be called ``i``.
-- 
2.30.0

Re: [PATCH] docs: Remove the Microsoft rhetoric

[Matthew Wilcox]

On Mon, Feb 08, 2021 at 04:04:48PM +0100, Yorick de Wid wrote:
> From: Yorick de Wid <yorickdewid@users.noreply.github.com>
> 
> There is no need to need to name Microsoft. The point is clear without that context.
> 
> Signed-off-by: Yorick de Wid <ydewid@gmail.com>
> ---
>  Documentation/process/coding-style.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 98227226c4e..5608ed2931f 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -306,8 +306,7 @@ that counts the number of active users, you should call that
>  
>  Encoding the type of a function into the name (so-called Hungarian
>  notation) is asinine - the compiler knows the types anyway and can check
> -those, and it only confuses the programmer. No wonder Microsoft makes buggy
> -programs.
> +those, and it only confuses the programmer.

I'm not opposed to this, but it'd be nice to distinguish between Systems
Hungarian (which is what this paragraph is correctly excoriating) and
Apps Hungarian (which is actually useful and we should do more of):

https://www.joelonsoftware.com/2005/05/11/making-wrong-code-look-wrong/

Re: [PATCH] docs: Remove the Microsoft rhetoric

[Jonathan Corbet]

Yorick de Wid <ydewid@gmail.com> writes:

> From: Yorick de Wid <yorickdewid@users.noreply.github.com>
>
> There is no need to need to name Microsoft. The point is clear without that context.
>
> Signed-off-by: Yorick de Wid <ydewid@gmail.com>
> ---
>  Documentation/process/coding-style.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 98227226c4e..5608ed2931f 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -306,8 +306,7 @@ that counts the number of active users, you should call that
>  
>  Encoding the type of a function into the name (so-called Hungarian
>  notation) is asinine - the compiler knows the types anyway and can check
> -those, and it only confuses the programmer. No wonder Microsoft makes buggy
> -programs.
> +those, and it only confuses the programmer.

Yeah, the time for that has probably passed.  Applied, thanks.

jon

P.S. This CC line in your original:

> Cc: Yorick de Wid <yorickdewid@users.noreply.github.com>, Yorick de Wid <ydewid@gmail.com>

Seems sure to create errors; maybe that could be left out in the future?