From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org, "Raj,
Ashok" <ashok.raj@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Tarun Gupta <targupta@nvidia.com>, Liu Yi L <yi.l.liu@intel.com>
Subject: Re: [PATCH v2 03/14] vfio: Split creation of a vfio_device into init and register ops
Date: Tue, 16 Mar 2021 20:12:33 -0300 [thread overview]
Message-ID: <20210316231233.GD3799225@nvidia.com> (raw)
In-Reply-To: <20210316151306.3829ef82@omen.home.shazbot.org>
On Tue, Mar 16, 2021 at 03:13:06PM -0600, Alex Williamson wrote:
> > > + void vfio_init_group_dev(struct vfio_device *device,
> > > + struct device *dev,
> > > + const struct vfio_device_ops *ops,
> > > + void *device_data);
> > > + int vfio_register_group_dev(struct vfio_device *device);
> > > + void vfio_unregister_group_dev(struct vfio_device *device);
> > > +
> > > +The driver should embed the vfio_device in its own structure and call
> > > +vfio_init_group_dev() to pre-configure it before going to registration.
> >
> > s/it/that structure/ (I guess?)
>
> Seems less clear actually, is the object of "that structure" the
> "vfio_device" or "its own structure". Phrasing somewhat suggests the
> latter. s/it/the vfio_device structure/ seems excessively verbose. I
> think "it" is probably sufficient here. Thanks,
Right, it says directly above that vfio_init_group_dev() accepts a
vfio_device so I doubt anyone will be confused for long on what "it"
refers to.
I got the other language fixes thanks
Jason
next prev parent reply other threads:[~2021-03-16 23:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 0:55 [PATCH v2 00/14] Embed struct vfio_device in all sub-structures Jason Gunthorpe
2021-03-13 0:55 ` [PATCH v2 03/14] vfio: Split creation of a vfio_device into init and register ops Jason Gunthorpe
2021-03-16 7:55 ` Tian, Kevin
2021-03-16 13:34 ` Jason Gunthorpe
2021-03-17 0:55 ` Tian, Kevin
2021-03-16 12:25 ` Cornelia Huck
2021-03-16 21:13 ` Alex Williamson
2021-03-16 23:12 ` Jason Gunthorpe [this message]
2021-03-16 12:54 ` Max Gurtovoy
2021-03-18 13:18 ` Auger Eric
2021-03-13 0:56 ` [PATCH v2 12/14] vfio: Make vfio_device_ops pass a 'struct vfio_device *' instead of 'void *' Jason Gunthorpe
2021-03-15 8:58 ` Christoph Hellwig
2021-03-17 11:33 ` Cornelia Huck
2021-03-13 0:56 ` [PATCH v2 14/14] vfio: Remove device_data from the vfio bus driver API Jason Gunthorpe
2021-03-16 8:22 ` Tian, Kevin
2021-03-17 12:08 ` Cornelia Huck
2021-03-17 23:24 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316231233.GD3799225@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=targupta@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).