From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA874C433DB for ; Thu, 18 Mar 2021 11:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BE8A64F2A for ; Thu, 18 Mar 2021 11:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbhCRL3l (ORCPT ); Thu, 18 Mar 2021 07:29:41 -0400 Received: from foss.arm.com ([217.140.110.172]:38682 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbhCRL3W (ORCPT ); Thu, 18 Mar 2021 07:29:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73110ED1; Thu, 18 Mar 2021 04:29:22 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5BAB3F792; Thu, 18 Mar 2021 04:29:20 -0700 (PDT) Date: Thu, 18 Mar 2021 11:29:10 +0000 From: Lorenzo Pieralisi To: Will Deacon Cc: Tom Saeger , linux-doc@vger.kernel.org, Jonathan Corbet , Thomas Tai , Konrad Rzeszutek Wilk , Catalin Marinas , Randy Dunlap , Al Stone , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ahs3@redhat.com, ardb@kernel.org Subject: Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT Message-ID: <20210318112859.GA25002@e121166-lin.cambridge.arm.com> References: <9efc652df2b8d6b53d9acb170eb7c9ca3938dfef.1615920441.git.tom.saeger@oracle.com> <20210318104433.GA6959@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318104433.GA6959@willie-the-truck> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org [+ Al, Ard] On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote: > [+Lorenzo] > > On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote: > > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead > > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection > > not depend on x86. > > > > Update arm64 acpi documentation, changing IBFT support status from > > "Not Supported" to "Optional". > > Opportunistically re-flow paragraph for changed lines. > > > > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/ > > > > Signed-off-by: Tom Saeger > > --- > > Documentation/arm64/acpi_object_usage.rst | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Lorenzo, please could you ack the change below if you're happy with it? > If so, I can take it as a fix. I don't see any issue with this patch, more so given that the IBFT legacy discovery method was decoupled from the ACPI table method, so it looks sound on ARM64. However, I would like to get Al and Ard opinions on this to make sure there is not something I am missing (in particular wrt the rationale behind the "Not Supported" in the docs). Lorenzo > Thanks, > > Will > > > diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst > > index 377e9d224db0..0609da73970b 100644 > > --- a/Documentation/arm64/acpi_object_usage.rst > > +++ b/Documentation/arm64/acpi_object_usage.rst > > @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories: > > > > - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT > > > > - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT, > > - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO, > > - TCPA, TPM2, UEFI, XENV > > + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT, > > + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, > > + STAO, TCPA, TPM2, UEFI, XENV > > > > - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT, > > - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT > > + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx, > > + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT > > > > ====== ======================================================================== > > Table Usage for ARMv8 Linux > > -- > > 2.31.0 > >