From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFF5C433C1 for ; Mon, 22 Mar 2021 07:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F15D61924 for ; Mon, 22 Mar 2021 07:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhCVHKP (ORCPT ); Mon, 22 Mar 2021 03:10:15 -0400 Received: from verein.lst.de ([213.95.11.211]:53776 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbhCVHJq (ORCPT ); Mon, 22 Mar 2021 03:09:46 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 99FE167373; Mon, 22 Mar 2021 08:09:44 +0100 (CET) Date: Mon, 22 Mar 2021 08:09:44 +0100 From: Christoph Hellwig To: "Maciej W. Rozycki" Cc: linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Christoph Hellwig Subject: Re: [PATCH 3/3] pata_legacy: Add `probe_mask' parameter like with ide-generic Message-ID: <20210322070944.GC3440@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org The interface looks a little strange, but I guess deviating from the old ide interface for something that has only such a use case in retrocomputing probably doesn't make much sense. Reviewed-by: Christoph Hellwig